Inlay hints

[milanjovanovic]

Inlay hints

[manateelazycat]

Inlay hint running in lsp-bridge-monitor-post-command function, maybe we need submit a inlay hint request to LSP server once we open some file.

[milanjovanovic]

I'm not talking about hints after opening file, I'm fine with current behaviour when opening new file.
This is already in open file that is already showing hints in the buffer, then I start typing new function for example:

So, it's not showing hints until I do C-k (kill-line).
After C-k

I can't figure out what is causing this behaviour because sometimes it does work ok (showing hints after Ret).
I'm trying to figure it out by myself but no luck for now, I would appreciate guidance where to look.
Thanks.

[manateelazycat]

Reference links:

• lsp-bridge/lsp-bridge.el

  Line 1199 in a3f5610

  (when lsp-bridge-enable-inlay-hint

• lsp-bridge/lsp-bridge-inlay-hint.el

  Line 92 in a3f5610

  (defun lsp-bridge-inlay-hint ()

• lsp-bridge/lsp-bridge-inlay-hint.el

  Line 128 in a3f5610

  (defun lsp-bridge-inlay-hint--render (filepath filehost inlay-hints)

I recommend that you first enable the option lsp-bridge-enable-log, then observe the return log of *lsp-bridge*. From my experience, there are only two reasons:

1. The lsp server returned an inlay hint message, and we have not fully parsed it.
2. The lsp-bridge-inlay-hint function is not sending enough; we need to increase the frequency of sending. Currently, inlay hint requests are only sent after modifying the code or scrolling the window.

Note that the lsp-bridge-enable-log option will affect performance. Please turn it off after debugging to avoid affecting your normal use.

[milanjovanovic]

I'm seeing that LSP-BRIDGE-INLAY-HINT--RENDER is not being called (when I edit file or press RET) until I do 'kill-line'.

LSP-BRIDGE-INLAY-HINT is being called all the time though.

What I'm seeing in project that doesn't work when I press RET is:

Recv message (error): { "jsonrpc": "2.0", "id": 30617, "error": { "code": -32801, "message": "content modified" } }

In project that works I get LSP-BRIDGE-INLAY-HINT--RENDER call all the time and no lsp-server errors like this.

[milanjovanovic]

This is from log, every time before the error I see this sequence, I don't know much about lsp protocol but it looks like second "didChange" call is invalidating "inlayHint" request ?

--- [17:07:55.093370] Send textDocument/inlayHint request (11744) to 'rust-analyzer' for project rsbom
--- [17:07:55.096867] Send textDocument/didChange notification to 'rust-analyzer' for project rsbom

Recv message (error):
{
"jsonrpc": "2.0",
"id": 11744,
"error": {
"code": -32801,
"message": "content modified"
}
}

[milanjovanovic]

This looks like some kind of race condition with LSP-BRIDGE-MONITOR-POST-COMMAND and LSP-BRIDGE-MONITOR-AFTER-CHANGE.
When I insert 50ms sleep in LSP-BRIDGE-MONITOR-POST-COMMAND it does work.

[manateelazycat]

@milanjovanovic Thanks for the detailed research. I have pushed the patch dfabfc8 to fix this problem. Please update and try again. ;)

[manateelazycat]

Please re-open this issue if update newest version still have problem.