Menu is missing on mobile layout

[faucetlol]

Menu is missing on mobile layout

[faucetlol]

Oh, it's intentionally hidden - I guess because removing that line it ends up with two menus if re621 is installed.

Considering the menu button doesn't even seem to do anything when RE621 is installed, I wonder if it should be removing that button itself, unless there's some clever CSS solution you can come up with.

[mandorinn]

Woke up a few minutes agoooo, didn't sleep 12 hours this time lmaooo
I totally didn't think about what'd happen if re621 wasn't installed on mobile!
Apparently re621 doesn't add data-enhancements to the body anymore, but it does add a few others such as data-sticky.
So, assuming that attribute is always added when re621 is installed, fixing the nav should be as easy as changing body.resp #maintoggle to body[data-sticky] #maintoggle, hopefully this fix works for you as wellllll!

[faucetlol]

Works perfectly!!

[mandorinn]

Sickkkkk! Hopefully that attribute doesn't get changed in the future like data-enhancements, tho it'd probably be an easy fix in the future if it doessss lollll

[faucetlol]

The hiding it actually only seems to work on the posts page, other pages still have it :(

Having an extra menu button is still better than users without RE621 getting no menu button at all though... I'm about to make a PR to just incorporate it into RE621 itself because there's really no need to ever have that button there when it has its own menu.

[bitWolfy]

Woke up a few minutes agoooo, didn't sleep 12 hours this time lmaooo I totally didn't think about what'd happen if re621 wasn't installed on mobile! Apparently re621 doesn't add data-enhancements to the body anymore, but it does add a few others such as data-sticky. So, assuming that attribute is always added when re621 is installed, fixing the nav should be as easy as changing body.resp #maintoggle to body[data-sticky] #maintoggle, hopefully this fix works for you as wellllll!

@mandorinn Both data-enhancements and data-sticky are used to turn specific portions of RE621 on and off.
The former toggles the profile page redesign, the latter – sticky search box.
Both are still being used, but neither can be relied on to detect whether RE621 is running or not.

I've added a new re621 attribute to body in 1.5.41 that is always set to true.