Giter Site home page Giter Site logo

Support 1.3 draft? about har-rs HOT 6 CLOSED

mandrean avatar mandrean commented on August 22, 2024
Support 1.3 draft?

from har-rs.

Comments (6)

rbtcollins avatar rbtcollins commented on August 22, 2024 1

As this is merged, closing.

from har-rs.

mandrean avatar mandrean commented on August 22, 2024

Nice! Yeah. Should be fairly simple to add. 🙌

from har-rs.

mandrean avatar mandrean commented on August 22, 2024

Ah, but the 1.3 proposal isn't an official draft but just a proposal by ahmadnassri, or am I mistaken?

from har-rs.

rbtcollins avatar rbtcollins commented on August 22, 2024

Its not entirely clear to me what it is; what is clear is that POST bodies with binary data are completely broken under 1.2, so I'd rather be able to opt-into an un-finalised thing than generate corrupt JSON :)

from har-rs.

rbtcollins avatar rbtcollins commented on August 22, 2024

Patch is up; if you like it, you could merge and push a release to crates? pretty please? :P.
There are other ergonomic things that could be done - e.g. storing the post body as a [u8] and auto setting the encoding and doing the base64 transparently etc; but just modelling whats there clearly is a pretty good start.

from har-rs.

mandrean avatar mandrean commented on August 22, 2024

Looks good! 👌I added a small comment on #5.

from har-rs.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.