Giter Site home page Giter Site logo

Comments (6)

rokibhasansagar avatar rokibhasansagar commented on June 2, 2024 1

Thanks for fixing it quickly πŸ˜ƒ

Both --use-chapter-title and --no-group-name inclusion or exclusion, with or without using --group option works perfectly.

Now, #36 is actually fixed without breaking anything.
So #37 can be resolved with the latest change.

You can push the new change to upstream for release.

from mangadex-downloader.

mansuf avatar mansuf commented on June 2, 2024 1

Side note: While figuring out this issue, if you could set the app to skip/ignore chapter links which redirects to non-mangadex links would be helpful (those are basically Licensed Uploader's website links).
I don't know how the mangadex API works, but if there is a way to filter the links before downloading them, I'd appreciate if you could implement it too in the near future.

This has been implemented in v2.5.1. The app will look for images not referral links. If the chapter doesn't have images it will simply skipped and will be not downloaded

from mangadex-downloader.

mansuf avatar mansuf commented on June 2, 2024 1

Released in v2.5.2

from mangadex-downloader.

rokibhasansagar avatar rokibhasansagar commented on June 2, 2024

Side note: While figuring out this issue, if you could set the app to skip/ignore chapter links which redirects to non-mangadex links would be helpful (those are basically Licensed Uploader's website links).
I don't know how the mangadex API works, but if there is a way to filter the links before downloading them, I'd appreciate if you could implement it too in the near future.

from mangadex-downloader.

mansuf avatar mansuf commented on June 2, 2024

Alright, this should be fixed in 9cebc81

I tested in my pc and it's fixed. Now if you could test it would be helpful. I will release this patch if you're satisfied with the results (due to obvious reason: Fixed one bug and another bug appeared)

Installation command:

pip install git+https://github.com/mansuf/mangadex-downloader.git@9cebc81b84df9b588d8f308a6b9fafd876ee3b44

from mangadex-downloader.

rokibhasansagar avatar rokibhasansagar commented on June 2, 2024

I'm testing it right now.
I'll inform about the new changes in a minute.

from mangadex-downloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.