Comments (9)
I guess then there's little risk in bumping the minimum deployment target without a major version increase ¯_(ツ)_/¯ Would you mind filing a PR to that effect?
Providing an xcframework would have the advantage that the target app wouldn't need to build the source code.
Yeah, I kinda want to offer this but I haven't made particularly great experiences with GH actions to automate this.
from mantle.
Do you mind checking if setting the minimum deployment target to 9 is enough to resolve this issue? (I don't use SPM for ObjC dependencies and I wouldn't be surprised if it took more than that to make this work.)
from mantle.
@robb sorry for not mentioning this, deployment target is iOS 12
.
From what I know the underlying problem is an Xcode problem and there have been equivalent issues in other SDKs, e.g. firebase/firebase-ios-sdk#6533
But since we are not using cocoapods anymore, I can't use a pod-post-install script to solve it.
from mantle.
Hmm, so there's nothing we can do? Would a precompiled XCFramework help? See #879.
from mantle.
Hmm, so there's nothing we can do?
This could be increased to .iOS(.v9),
.
https://github.com/Mantle/Mantle/blob/master/Package.swift#L9
I would say it's safe to assume that people using SPM are using Xcode 12 and therefore the minimum deployment target is iOS 9
. But again, this is just an assumption :)
Would a precompiled XCFramework help? See #879
I'm honestly not sure what #879 is asking for? 🤔
from mantle.
Haha, I completely forgot that we have a Package.swift
😵💫.
I would say it's safe to assume that people using SPM are using Xcode 12
That sounds like a reasonably assumption. However, for this to work, we would also have to raise the minimum deployment target in the Xcode project, right? That would technically be a breaking change that required a new major version. I have a feeling that Mantle skews towards older apps. Do you happen to know if Apple still lets you submit iOS 8.0 apps to the store?
I'm honestly not sure what #879 is asking for? 🤔
I think they are asking for the ability to download a zipped XCFramework from GitHub's release page. My understanding is that could also be used by SPM to download a binary artifact.
from mantle.
Do you happen to know if Apple still lets you submit iOS 8.0 apps to the store?
Starting April 26, 2021, all iPhone and iPad apps submitted to the App Store must be built with Xcode 12 and the iOS 14 SDK or later
Xcode 12 has the minimum deployment target of iOS 9, hence also the warning.
My understanding is that could also be used by SPM to download a binary artifact.
👍
Providing an xcframework would have the advantage that the target app wouldn't need to build the source code.
from mantle.
from mantle.
Closed in #886
from mantle.
Related Issues (20)
- Potential leak of memory reported by Xcode static analysis HOT 1
- FR: Add xcframework in a zip file in tag version on github HOT 1
- Map multiple json field when key name is same HOT 2
- Parsing array with objects of different subclasses
- FR: Add precompiled xcframework in assets. HOT 4
- fix build for Xcode 12.5 HOT 1
- Document is so difficult to understand and still so complex to use HOT 2
- Should auto transform json value type to property type without create transformer HOT 2
- JsonToModel error HOT 2
- Getting crash in iOS 15
- Can't install version 2.2.0 using pods HOT 7
- Handling null values when mapping to a BOOL property HOT 4
- Mantle crashes on iOS 16 due to WorkflowKit containing an unprefixed Mantle copy HOT 6
- strncpy code security issue HOT 2
- Error when activating code coverage HOT 2
- dSYM files of Mantle HOT 3
- Redefinition of enumerator 'MTLModelEncodingBehaviorExcluded' HOT 1
- Excuse me. Is there any plan to release the next release? When is the release planned? HOT 1
- Support the optional property attributes in mtl_copyPropertyAttributes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mantle.