Memory leak in pac_utils.h

[yoav-lapin]

Memory leak in pac_utils.h

[fralken]

Hello,
the tmporig pointer has moved in this snippet

    while (count--) {
        ins = strstr(tmporig, rep);
        len_front = ins - tmporig;
        tmp = strncpy(tmp, tmporig, len_front) + len_front;
        tmp = strcpy(tmp, with) + len_with;
        tmporig += len_front + len_rep; // move to next "end of rep"
    }

hence the free(tmporig); doesn't work since tmporig doesn't point to the start of the buffer.
Since the buffer pointed by orig parameter is not modified inside the function, there is no need to duplicate it.
So, instead of doing

    char *tmporig = malloc(strlen(orig) + 1); // Copy of orig that we work with
    tmporig = strcpy(tmporig, orig);

it should be enough doing instead

    char *tmporig = orig;

so there is no need to perform a free() in the end, and no memory leak is created.

[manugarg]

Good catch, @fralken. My C-foo is pretty rusty now, but we don't really need to even create a copy of orig, right? We could simply use orig; it won't modify the underlying string

[fralken]

Indeed you are right @manugarg since orig itself is a copy of the pointer to the input string.