Comments (6)
1ec5
commented on August 23, 2024
Currently, the method returns an MBMImage, so developers have to call cgImage() to get an unmanaged CGImage, then call takeUnretainedValue() or takeRetainedValue() depending on the situation. This is error-prone and could lead to crashes or memory leaks such as the one fixed in mapbox/mapbox-navigation-ios#2880. I think it would be pretty important for a Swift-first SDK (or even an Objective-C-first SDK) to avoid exposing unmanaged memory to client code.
/cc @MaximAlien
from mapbox-maps-ios.
zugaldia
commented on August 23, 2024
/cc: @knov
from mapbox-maps-ios.
zugaldia
commented on August 23, 2024
Would the recommendation require breaking API changes?
from mapbox-maps-ios.
zugaldia
commented on August 23, 2024
Why was this ticket closed?
from mapbox-maps-ios.
1ec5
commented on August 23, 2024
This appears to have been fixed in #321.
from mapbox-maps-ios.
S2Ler
commented on August 23, 2024
Fixes another leak: #562
from mapbox-maps-ios.
Related Issues (20)
- Snapshotter `pointForCoordinate` incorrect when using style with built in terrain.
- Invalid Privacy Manifest HOT 1
- [Bug] Xcode 16.0 - Cannot convert return expression of type '[UIView : ViewAnnotationOptions]' to return type 'Dictionary<String, Optional<JSONValue>>.RawValue' (aka 'Dictionary<String, Optional<Any>>') HOT 1
- Allow applying a shader to a raster layer.
- Can't install on SPM - invalid archive errors HOT 4
- `onMapLoaded` / `onMapLoadingError` not called upon startup HOT 4
- Any plan to support building with xcode 16 on 10.12.x? HOT 2
- How to use `CustomGeometrySource`
- [GestureSettings] Align the name between Android and iOS HOT 1
- Error `called from a thread that is not owning the object` HOT 1
- Can't animate moving `MapViewAnnotation` HOT 3
- Puck snaps to wrong roads HOT 3
- Disable long press gesture on map HOT 4
- GeoJSON Source Loads Data Even When Layer is Hidden HOT 1
- Offline Load Tile Region in version above 11.3 not work with custom style.
- Interprocess communication with main thread when returning `compatibleAuthorizationStatus` HOT 1
- [Error, maps-core]: {}[Style]: Failed to load tile 5/5/12=>5 for source composite: HTTP status code 401 HOT 1
- Need Help in coverting a mapbox function HOT 1
- Adding a polyline with a set .linePattern property breaks other polyline annotations inside of the same annotation manager
- .netrc file in Github Actions? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapbox-maps-ios.