Giter Site home page Giter Site logo

Comments (5)

HarelM avatar HarelM commented on June 10, 2024

I would say that I hoped maptiler would be inclined to fix this, but they have their editor, so I'm not sure any help would come from there.
Having said that, maputnik codebase is small and you should be able to find and fix this issue.

from maputnik.

HarelM avatar HarelM commented on June 10, 2024

The code around replacing the access token is weird, and potentially buggy, or does not expect this flow.
Since the keys should be part of the style, I believe you should simply set them in the relevant source and not expect maputnik to replace it.

Bottom line, more of a feature than a bug :-)

from maputnik.

rsalzer avatar rsalzer commented on June 10, 2024

Then the bottom line would be to remove those fields which suggest that it works ;)

A better flow would probably be to offer values which maputnik replaces ... {key} or {maptilerKey} and then replaces them everywhere.

from maputnik.

HarelM avatar HarelM commented on June 10, 2024

It works for glyphs and maybe sprites I believe.
But for sources there's a bunch of code that I didn't understand...

from maputnik.

rsalzer avatar rsalzer commented on June 10, 2024

Probably it would be quite easy to add a possibility to add variables (in the shape of {variable}) which then can get replaced. Like this it would be universal ... I might add a PR

from maputnik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.