AnimatedPointSample doesn't stop work

[charlenni]

AnimatedPointSample doesn't stop work

[pauldendulk]

I looked into this. I think we need to implement IDisposable for the samples. I think Thomas mentioned this somewhere before and then the argument came up that the samples are there to show the users how things work and should not be cluttered too much with this kind of thing. In this case it will affect performance noticeably so I think we now have too.

How to keep the samples readable:

• Perhaps only Dispose the fields if really needed, and ignore it in other situations.
• Reorganize Mapsui so that the layers and providers are not disposable. The data fetcher should be a central component (most of the time it is the http request or db requests that needs to be disposed) and let the layer be simple data definitions.

[pauldendulk]

Looked a bit more at the code. Disposing samples would need us to store the previous sample, which we don't do at the moment. Perhaps we need to introduce some SampleService for that. A class which could be shared through all our samples. Perhaps some more logic around the samples could be moved in there, for instance access to the list of samples returned by the AllSamples.GetSamples() method, selecting the sample corresponding to the name.

I suggest that the first version of the disposable samples would not add IDisposable to the sample interface, but just for specific ones we decide to dispose, and check for each sample if they implement the interface.