Requesting range off end of file does not return 416 status code

[timj]

Requesting range off end of file does not return 416 status code

[mar10]

Yes, I also looked into it a bit yesterday. As I understand it, invalid Range headers may result in a

• Response 200, returning the complete file,
  or
• Response 416 with Content-Range: bytes */FILESIZE

I will try to get the latter working. (Multi-Part responses are currently not implemented btw.)

[timj]

I did have a quick look at the code and the error occurs in util.obtain_content_ranges. The first match in the loop does correctly determine the first and last byte ranges but does not check to see if firstpos > filesize. Instead it drops out of that block and then tries the second match with reSuffixByteRangeSpecifier.search. This time it ends up doing firstpos = filesize - larger_number and gets a negative answer which it then turns into firstpos = 0 and you end up with the whole file.

I did get the simple case to work by adding a check for firstpos > filesize in the first check block and then immediately returning [], 0 -- what I'm not sure about is what should happen if you ask for multiple ranges and only one of them is unsatisfiable.