Warnings

[finestructure]

Warnings

[MarcoEidinger]

Great, I am out of town and will probably update V2 release on Wednesday or Thursday. If you notice any issues in the meantime then please let me know

[MarcoEidinger]

V2 points to the latest (2.3.4) release

[finestructure]

NB: I don't think it's our action still using checkout@v2, I updated that recently.

[MarcoEidinger]

reusableWorkflow.yml is using peter-evans/create-pull-request@v3 and using v4 will get rid of node depreciation warning.

PR will follow to uptake new dependency version

[MarcoEidinger]

Also the use of set-output in entrypoint.sh needs to be replaced as those statements are deprecated.

Will follow up on this as well

[finestructure]

reusableWorkflow.yml is using peter-evans/create-pull-request@v3 and using v4 will get rid of node depreciation warning.

Ah great, thanks for the quick reply and for taking a look!

[MarcoEidinger]

@finestructure can you test against the main branch that there are no unexpected errors? Once confirmed then I will apply the changes to V2

[finestructure]

I'm not sure if I'm doing this the right way or if there's an issue. I've created a branch test-pkg-dep and changed reusableWorkflow.yml@v2 to reusableWorkflow.yml@main. However, that gives me:

Error: Unable to resolve action `MarcoEidinger/swift-package-dependencies-check@eliminateWarnings`, unable to find version `eliminateWarnings`

when running the action.

Is this the correct way to test main?

[finestructure]

Mmm, looks like that branch eliminateWarnings does indeed not exist in the repo. Did you perhaps not push it?

[MarcoEidinger]

@finestructure sorry that code change was a leftover from earlier testing. I pushed a fix and using main branch should work now

[finestructure]

Great, that's working fine now! Thanks for the quick fix!

[MarcoEidinger]

Release 2.3.4 got published by me