Packages and Python built-in imports are not supported when the project has somewhere a folder with the same name

[marcogorelli]

Packages and Python built-in imports are not supported when the project has somewhere a folder with the same name

[AIGeneratedUsername]

Thank you for the update. Now all works correctly.

[MarcoGorelli]

Thanks @AIGeneratedUsername for the report

TBH having a folder which has the same name as a package you're using feels like an anti-pattern

Check that import is a 3rd-party package. Do not make such imports relative.

currently the tool only performs static analysis, so this wouldn't be an option

Another possible solution is to allow to ignore manually specific names. For example, I will ignore names "collections" and "google".

I'd rather not add such complexity

IMO the simplest solution is to change your local file structure

I'd accept a PR to document this gotcha though

[AIGeneratedUsername]

I agree that names shadowing is not nice, but there is a bug in this package.

Consider the following structure:

backend/
     src/
         __init__.py
         spameggs/
              __init__.py
              foo/
                    __init__.py
                    some_file.py
              bar/
                    __init__.py
                    another_file.py

Imagine that "some_file.py" has content:

from spameggs.abc import something

absolufy-imports thinks that this import is correct and that it is imported a folder above. absolufy-imports is wrong. It is easy to detect that it is wrong. No dynamic imports are required.

absolufy-imports will change it too

from ..abc import something

---

So, the bug is:

absolufy-imports changes to relative WRONG imports

New (fixed) logic:

1. Iterating over directors and files. REMEMBER DIRECTORY DEPTH!
2. Can from spameggs.abc import something be imported?
   YES: refactor the import to be absolute!
   NO: it is either a wrong import or external package. IGNORE! DO NOTHING!

---

I hope my idea explanation is not too cumbersome.

[MarcoGorelli]

Thanks for your explanation - do you want to submit a pull request to fix this?

[AIGeneratedUsername]

I need to force relative imports usage in the "src/" directory. I did a research over similar packages and there is no package that do exactly what is required for me. Since my use case is rare, this issue becomes low-priority for you. I did not look at your code, but probably the simplest way to achieve my goal is either to create a pull request or fork the package. I will do this, but I can not give any time estimations (when I will have some time).

[MarcoGorelli]

Since my use case is rare, this issue becomes low-priority for you

It's more that I have a full time job and any work I do on this package in purely voluntary

If you submit a pull request I'll review it, else I'll get to this when I get a chance

Thanks anyway for your report!

[MarcoGorelli]

I'd like to think this is fixed in version 0.3.1 - could you check please?