major bugfixes to array.c and strdict.c

[markcox]

major bugfixes to array.c and strdict.c

[GoogleCodeExporter]

merged with svn commit 304

Original comment by [email protected] on 10 Feb 2009 at 9:36

• Changed state: Verified

[GoogleCodeExporter]

Dan,

since this patch has been applied to svn, the test program (bin/proxy) crashes 
here
on px_proxy_free. Can you reproduce this?

I reverted (on my local tree only) the part of the patch which touches array.c 
and
the segfault disappears.

Interestingly, the segfault also disappears when I remove the webkit plugin. You
might not have it and thus not trigger the segfault at yours.

Original comment by [email protected] on 27 Feb 2009 at 10:01

• Changed state: Accepted

[GoogleCodeExporter]

Nope, doesn't crash for me.

webkit's on_proxy_factory_destantiate() does:

    ctxs_free(px_proxy_factory_misc_get(self, "webkit"));

before the patches, that would have been a no-op, so I think it's likely that 
the
strdict fixes are exposing a bug in the webkit plugin.

Skimming the code, it looks like if the webkit plugin tries to run a PAC script 
but
gets an error, then this would cause a crash later, because webkit_pacrunner() 
calls
ctxs_free() in that case, but doesn't call px_proxy_factory_misc_set(self, 
"webkit",
NULL), so the same context will get freed again later.

Original comment by [email protected] on 4 Mar 2009 at 9:20

[GoogleCodeExporter]

Dan.. Thanks for the explanation.

I'll create a follow-Up ticket for the webkit plugin. Closing this ticket here 
again. 

Original comment by [email protected] on 11 Mar 2009 at 3:53

• Changed state: Fixed