[PATCH]libproxy 0.2.3 fail to compile with mozjs support

[markcox]

[PATCH]libproxy 0.2.3 fail to compile with mozjs support

[GoogleCodeExporter]

PS: see the bug https://bugs.gentoo.org/show_bug.cgi?id=259178

Original comment by [email protected] on 12 Apr 2009 at 5:54

[GoogleCodeExporter]

Romain,


There were already plenty of jspai redetection fixes in svn. Can you please 
test if
those would not be enough already?

That would be very helpful.

Original comment by [email protected] on 4 May 2009 at 8:32

[GoogleCodeExporter]

I tested this myself now on a gentoo 2008 installation using trunk.

It compiles just fine, including the mozilla plugin. So one of the previous 
fixes for
the jsapi detection solved this already.

Original comment by [email protected] on 15 May 2009 at 10:34

• Changed state: Fixed

[GoogleCodeExporter]

This is not fixed by far. You have shuffled everything around and caused further
breakage with xulrunner-1.9.1_rc1. The proper fix would be to just pkg-config 
check
libxul-unstable for CFLAGS if your gonna depend on headers from unstable.

Original comment by [email protected] on 23 Jun 2009 at 3:47

[GoogleCodeExporter]

Index: configure.ac
===================================================================
--- configure.ac    (revision 393)
+++ configure.ac    (working copy)
@@ -26,9 +26,10 @@
 PKG_CHECK_MODULES(xmu, xmu, have_xmu=yes, have_xmu=no)
 PKG_CHECK_MODULES(webkit, webkit-1.0, have_webkit=yes, have_webkit=no)
 PKG_CHECK_MODULES(mozjs, xulrunner-js, have_mozjs=yes, 
+       [PKG_CHECK_MODULES(mozjs, libxul-unstable, have_mozjs=yes,
        [PKG_CHECK_MODULES(mozjs, firefox-js, have_mozjs=yes,
        [PKG_CHECK_MODULES(mozjs, mozilla-js, have_mozjs=yes, 
-       [PKG_CHECK_MODULES(mozjs, seamonkey-js, have_mozjs=yes,have_mozjs=no)])])])
+       [PKG_CHECK_MODULES(mozjs, seamonkey-js, have_mozjs=yes,have_mozjs=no)])])])])
 PKG_CHECK_MODULES(NetworkManager, NetworkManager dbus-1, 
                    have_networkmanager=yes, have_networkmanager=no)


This would be your proper fix for the issue to ensure both forward and backward
compatiblity.

Original comment by [email protected] on 23 Jun 2009 at 3:55