Comments (7)
there is also bug with page size on line 76 of same file
from shipstation4net.
Shipments & Products most likely have bug in pagination as well
If you pass filter, then page & pagesize variables are ignored
line 59: https://github.com/nla-brandonjames/ShipStation4Net/blob/master/ShipStation4Net/Clients/Shipments.cs
and line 64: https://github.com/nla-brandonjames/ShipStation4Net/blob/master/ShipStation4Net/Clients/Products.cs
from shipstation4net.
Question #2 that i had - do you plan to maintain this project or it is just something which was built as 'example of work'. I understand that if shipstation will provide their own client package on nuget, then there will be no reason to maintain different implementation of Api client. Just trying to get better idea what i could rely on.
from shipstation4net.
Hey,
Thanks for using this library. I created this in a week, and I am intending to upgrade the core ClientBase and related code as a separate REST Client along the way some time. I was expecting for there to be some issues. I was rushing. I also have a Zoho Client that I should be publishing sometime too. Also, I have seen your Pull Request and will review it shortly. I will be using the library to integrate into some internal applications for my business. Eventually ShipStation will be phased out here and this Client was made just for that purpose to make it easier to sever the tie. I have not implemented the bulk update yet. The core code doesn't have file support yet.
from shipstation4net.
I think that error has to do with missing 'configuration.json' file in test project. When I got latest of this repo, this file was missing, and I assumed it's because this file contained some api credentials that were not supposed to be exposed.
on the other hand, even if file would be present, I think that master branch would still fail to pass all tests - current build status of master branch is "failing": https://ci.appveyor.com/project/nla-brandonjames/shipstation4net/branch/master
in this log you might see that ApiLimitReachedException is thrown in 4 test cases.
2 errors because [shipDate] should be nullable on order DTO..
ShipStation4Net.Tests.TestStores.TestGetStoreAsync test throws 'Bad Request' exception.
from shipstation4net.
OK. Yeah, the appveyor.yml file has credentials encrypted in it. I'm assuming it throws because it can't read the API Limit from the file in the tests. Most of the failed tests from the main branch were the reasons due to the API limit. The configuration.json file has the details. I can tell for the most part you just changed the affected files.
from shipstation4net.
Accepted PR #3.
from shipstation4net.
Related Issues (17)
- Async optimizations HOT 3
- Question: Suggested improvements HOT 2
- Unit test execution HOT 2
- .NET 4.5+ compatibiltiy HOT 5
- Store Refresh does not work for refresh all as stated in the documentation HOT 1
- Maintaining this Library HOT 5
- product length, width, height, weight change form int to double HOT 1
- Feature: Creating/Updating multiple orders HOT 2
- Getting resources for order shipped notifications not working HOT 1
- Shipments.VoidLabelAsync return value issue HOT 1
- Orders.GetAllPages() errors because of new insurance provider HOT 2
- Issue Getting Async Data HOT 3
- Fulfillments does not implement IGetsResourceUrlResponses HOT 1
- Client interfaces are not able to be mocked HOT 4
- OverflowException: Value was either too large or too small for an Int32. HOT 1
- The insuranceCost in ShipmentLabel has changed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shipstation4net.