Images won't load with Ruby 1.9.2 and Rails 3

[markevans]

Images won't load with Ruby 1.9.2 and Rails 3

[markevans]

Hi Jon
Thanks for this - yes this is also something my colleague experienced.
Does your patch definitely need the 'if' clause?
I'm wondering if it's a good idea to always set it to binary mode.
thanks
Mark

[JonRowe]

The if clause is purely because I was uncertain as to the affects of writing actual encoded strings in this fashion;

ASCII-8BIT being a synonym for binary/raw string "encoding" I am fairly certain this is safe to place the file's IO stream into binmode, but according to the ruby docs, http://ruby-doc.org/core/classes/IO.html#M002292, this is irreversible for the lifetime of the file.

So I was merely being cautious.

[markevans]

ok thanks a lot - I'll have a look into it

[markevans]

I've added that tempfile.binmode line to v 0.7.6 - it seems to work fine with other versions of Ruby and tests all pass, so I've not used the if clause.
Thanks again