[BUG] markmap --watch --offline not working

[MarcoBuess]

[BUG] markmap --watch --offline not working

[gera2ld]

It looks like a network issue. The offline mode works by downloading all assets in advance.
Can you access the assets directly?

https://cdn.jsdelivr.net/npm/[email protected]/dist/browser/index.min.js

[MarcoBuess]

Looks like so. But does that even make sense? Its literally like an offline mode that doesn't work offline. It also doesn't look like it works offline even with an active connection. It doesn't seem like it caches the assets locally to have it really work offline?

[gera2ld]

The offline mode works by downloading the assets in advance during installation. The installation still requires a network. Now the issue is that installation failed due to a network problem.

BTW does any CDN that serves npm package files work for you? I can tell that both jsdelivr and unpkg do not.

[MarcoBuess]

So I'm behind a corp. firewall. It is usually fine with npm but I can't tell for anything beyond that. So what you're saying is, if e.g. I have a non restricted connection the -offline switch would download the assets and it should work from then on, or I have to do a whole reinstallation of markmap with a non restricted connection?

[MarcoBuess]

@gera2ld So I tried both. It looks like it tries to download the assets again everytime your run it, no matter if it ran sucessfully before. Outside the corp. network, I can run with -offline just fine. I also reinstalled v0.16.1 outside the corp. network. As soon as I reconnect to the corp. network it stops working.

[gera2ld]

Seems something is wrong with paths after installation. Let me fix it.

Fixed in 0.16.2

[MarcoBuess]

@gera2ld Can confirm it's working now. Thanks. 👍

[MarcoBuess]

@gera2ld Is it intended that this now also works with just -watch? If there is handling that automatically falls back to the locally cached assets I guess you could drop --offline alltogether?

[gera2ld]

--offline means the generated HTML file can be loaded offline, i.e. all static assets are inlined.
If all the assets are downloaded successfully on installation, you don't need a network to use it, no matter if --watch is set.
An exception is that Katex requires font files that must be downloaded from the CDN.