Gunicorn returns 404

[ayan4m1]

Gunicorn returns 404

[markstory]

I'm not sure what the problem you're having is. I'm not able to reproduce it locally. I ran docker compose up which pulled down several images. Once all the services were running docker inspect --format "{{json .State.Health }}" lint-review_web_1 returned the following

{"Status":"healthy","FailingStreak":0,"Log":[
  {"Start":"2019-07-31T01:59:09.8513175Z","End":"2019-07-31T01:59:10.1255362Z","ExitCode":0,"Output":"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\n                                 Dload  Upload   Total   Spent    Left  Speed\n\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0\r100    25  100    25    0     0   2802      0 --:--:-- --:--:-- --:--:--  3125\nlint-review: 2.12.1 pong\n"},
  {"Start":"2019-07-31T01:59:20.1467486Z","End":"2019-07-31T01:59:20.3609946Z","ExitCode":0,"Output":"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\n                                 Dload  Upload   Total   Spent    Left  Speed\n\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0\r100    25  100    25    0     0   1397      0 --:--:-- --:--:-- --:--:--  1470\nlint-review: 2.12.1 pong\n"},
  {"Start":"2019-07-31T01:59:30.3807698Z","End":"2019-07-31T01:59:30.651296Z","ExitCode":0,"Output":"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\n                                 Dload  Upload   Total   Spent    Left  Speed\n\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0lint-review: 2.12.1 pong\n\r100    25  100    25    0     0   1331      0 --:--:-- --:--:-- --:--:--  1388\n"},
  {"Start":"2019-07-31T01:59:40.6631892Z","End":"2019-07-31T01:59:40.8187857Z","ExitCode":0,"Output":"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\n                                 Dload  Upload   Total   Spent    Left  Speed\n\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0lint-review: 2.12.1 pong\n\r100    25  100    25    0     0   2286      0 --:--:-- --:--:-- --:--:--  2500\n"},
  {"Start":"2019-07-31T01:59:50.8416773Z","End":"2019-07-31T01:59:50.9939845Z","ExitCode":0,"Output":"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\n                                 Dload  Upload   Total   Spent    Left  Speed\n\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0\r100    25  100    25    0     0   2923      0 --:--:-- --:--:-- --:--:--  3125\nlint-review: 2.12.1 pong\n"}
]}

I didn't set LINTREVIEW_SERVER_NAME or LINTREVIEW_GUNICORN_DEBUG in my environment variables. Perhaps that is the source of your problems? The healthcheck scripts attempt to reach localhost:5000. One possibility that I can see is that the healthcheck script needs to use 127.0.0.1:5000 or the IP defined in SERVER_NAME?

[ayan4m1]

OK, omitting LINTREVIEW_SERVER_NAME resolves the health checks returning 404. I think where I got confused was reading the following in the README: For the most basic installation you'll need to set GITHUB_OAUTH_TOKEN, and LINTREVIEW_SERVER_NAME. Would you be amenable to a PR clarifying when it is and isn't required? I can write one up if you can summarize the logic for me - Python isn't my strong suit and I'm having a bit of trouble finding references to SERVER_NAME in the codebase. EDIT: Thanks for your help!

[markstory]

Sure. An update to the readme would be great. The SERVER_NAME variable ends up going into gunicorn, and does what the gunicorn docs say.