Giter Site home page Giter Site logo

Comments (3)

justinsalamon avatar justinsalamon commented on June 11, 2024

This sounds like a good plan to me. A few things to note:

  1. Since we need a solution for all models, I'm not sure it makes sense to just add tiny to pypi (this is not an urgent matter) - it feels messy. We might as well work directly on the final solution which downloads all the models from the GH repo (maybe still include the full model on pypi, and download all the other models from gH) and only then push to pypi.
  2. We should ensure that the option to choose a smaller model is also available via the python API, not just the CLI
  3. Once all the above is implemented we should bump the version, create a new release on GH and push to pypi (using twine to ensure correct markdown display on pypi).

from crepe.

jongwook avatar jongwook commented on June 11, 2024
  1. Once I add the implementation for handling multiple models, the updated Python code under /crepe/ can stay the same when we change the storage to GH - so I'd say it's more gradual path toward the solution.

I'm inclined to downloading all models from GH if possible, because including the same model for every release is a waste/abuse of PyPI storage.

  1. Sure; the CLI will call the appropriate python API.

  2. Of course.

from crepe.

justinsalamon avatar justinsalamon commented on June 11, 2024

OK, sounds good. Let me know if you need my help with any of this, cheers.

from crepe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.