Swagger isn't obeying required=True for IPv4 field

[cjproud]

Swagger isn't obeying required=True for IPv4 field

[lafrech]

Fixed in apispec 6.6.0.

Thanks.

[lafrech]

Not sure what happens, here. The field is displayed as required.

The difference I see is that the IP field is not a "string" field. We may want to improve this.

As per https://swagger.io/docs/specification/data-models/data-types/, we could define the type as string and the format as ipv4.

This should be an easy contribution. It happens here in apispec: https://github.com/marshmallow-code/apispec/blob/dev/src/apispec/ext/marshmallow/field_converter.py#L23. Let's add ipv4, ipv6 and ip if for the IP field.

Would you like to take a stab at it?

[cjproud]

Sure thing - I'm about to knock off for the day but can give it a stab tomorrow.

Quick question (and definitely a dumb one), I haven't done development on a package dependency before...if I clone marshmallow-code/apispec to my machine how do I tell flask-smorest to use that as a dependency rather than the version from PyPI?

[cjproud]

I should clarify, I want to do the above to test that my changes work 👍

[lafrech]

Thanks for this.

In your flask-smorest virtualenv, install your modified apispec with pip install -e.

[cjproud]

Hey @lafrech I've just made a PR in apispec: marshmallow-code/apispec#892. I hope that's what you were looking for :)