Comments (23)
any update on this issue?
which direction should I look at if I want to implement this feature?
(cljs newcomer)
from s3-beam.
Still would be nice to have but I currently don't use s3-beam for anything that would require it. If you'd like to tackle it I'd be happy to discuss options, review code etc.
from s3-beam.
Ah ok. Well I'm going to need to use it soon (implementing direct uploads in my app, and would like progress), so I might have a look at it. :) thanks. I'll close this until then.
from s3-beam.
Alright. Feel free to ping me if you have any questions.
from s3-beam.
I'm just going to leave a reference to this here for later: google/closure-library#465 so that I can watch it, because it's pertinent.
from s3-beam.
Cool, @martinklepsch looks like progress events are now supported in Google Closure library as at google/closure-library@1e0c810 which is August 26, 2015 (yesterday). I'm pretty sure the clojurescript library doesn't include the very latest closure library, so I guess we wait until David Nolan rolls this into CLJS main and releases another patch/update so we can bump the required dependencies.
Current CLJS is 1.7.48 as you no doubt know but not sure what version that tracks... the tagged version after the prerelease (1.7.58) seems to be 1.7.107 (given you're a contributor to it), which tracks 0.0-20150805-acd8b553 which is still about 22 days ago... any chance you can help this along, some? :)
I don't know the machinations of what's proper and possible here. I also don't know how google release their closure code, seeing as their github doesn't seem to track releases, only commits.
from s3-beam.
Awesome! I think updating the Closure library that comes with CLJS is a matter of bugging @swannodette to do so. AFAIK there's not much work to it so it shouldn't take too long.
There are a bunch of scripts in the Clojurescript repo to help with this as well in case you want to play around locally.
from s3-beam.
I'm not entirely sure how to bug @swannodette actually... do you think he'll notice if we mention him here? I don't know if that's how github works.
@swannodette if you do notice this, would you mind terribly updating clojuresrcipt to bump the version of Google Closure library to include the new upload progress work?
from s3-beam.
@martinklepsch Does github notify david when I mention him here? I can't actually open an issue on the clojurescript repo because they're not using the issue tracker.
from s3-beam.
Oh... scratch that. Seems he bumped it 26 minutes ago! :) Great now I just have to wait for him to do a release and then get you to bump the CLJS version :). clojure/clojurescript@1b8b492
from s3-beam.
Actually that's just the compiler but I think he'll bump the lib as well now :)
from s3-beam.
Cool. :)
from s3-beam.
Watch this for a new release: http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.clojure%22%20closure
If you then specify those libs as explicit deps they will be used instead of CLJS default ones. Alternatively wait until later today for a new CLJS release with updated closure libs.
from s3-beam.
No hurry. Sorry for the noise. I won't get to this for at least a day or two, and possibly no sense starting this until the previous PR is accepted, as it'd need error reporting to some degree, too. :) Awesome! Thanks.
from s3-beam.
Status report on this? @GetContented have you started work on this?
from s3-beam.
Hey Kenny. My last PR 21 wasn't accepted yet. I don't know why. It was requisite to this work. However, I didn't actually got to doing upload progress because of the requisites not being in place in the Google closure and CLJS requirements.
I stopped work on the clojurescript version of the project I'm working on a few months back so I probably won't implement this. I don't think it's too much work, though, on top of PR-21. If you need it, you'll probably need PR-21 to be accepted or something that does the same work. @bensu tried to get a PR of a similar nature in once before around similar lines. I'm not entirely sure why @martinklepsch didn't accept PR-21. Maybe we could ask him ? :)
from s3-beam.
It's not that @martinklepsch didn't accept my PR, but it is incomplete. I am not currently using the project but my circle around to finish it anyway.
from s3-beam.
@bensu fair enough. Mine is complete, but I think it's slightly in conflict with yours as I went about things in a slightly different manner... mine is a little bigger in terms of features, though, because I was building it with a view to upload progress later.
from s3-beam.
@GetContented if you feel yours will be better, I won't push mine further/deal with the conflicts later. Go ahead and continue to work ignoring my PR!
from s3-beam.
@bensu I have no idea - yours didn't do what I needed, and I've been using my PR since I put it up here, but the fact that it hasn't been accepted is a bit curious to me. Not sure why. :)
from s3-beam.
@GetContented I think I didn't merge this back then because we were still waiting for a new version of the Closure Library getting bundled with ClojureScript.
It seems that either 1.7.122
or maybe even 1.7.145
is required. Adding a note to the Readme about the version requirements of s3-beam would probably be a good idea given these releases are fairly. recent.
As for #21 I'll reply there.
from s3-beam.
Ahem.. I got confused. The new release is only required for the progress stuff which is TBD.
from s3-beam.
@altV my project didn't end up requiring it (because I started to rewrite the next version of it in Haskell).
This isn't a huge amount of work, though, I don't think. I did the precursor stuff that was required. You just need to integrate Google's closure library (with an S) upload progress.
from s3-beam.
Related Issues (20)
- Internet Explorer 9 support? HOT 5
- readme needs adjument? (custom signing url) HOT 2
- Errors HOT 9
- Way to extend headers and parameters sent to signing endpoint on server HOT 2
- clojars release HOT 2
- Assert content type is not null
- Provide acl in headers rather than form data? HOT 1
- Cut a new release? HOT 3
- Add support for Signature Version 4 HOT 3
- Use AWS Java SDK for signing URL HOT 2
- Refactor into a callback based API and layer core.async on top? HOT 2
- Don't use `first` with HTMLCollection
- JavaScript Equivalent HOT 2
- setting "Content-Dispoition": "attachment" ? HOT 4
- re-frame component HOT 1
- aws-zone not required when passing custom upload-url HOT 7
- Switch to using virtual-host style URLs when possible HOT 1
- Reagent/Re-frame example? HOT 2
- us-east-1 zone must be set to "s3" in server side configuration. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s3-beam.