[Bug] Handlers cannot be marked as 'Internal', and consumed by another Assembly

[martinothamar]

[Bug] Handlers cannot be marked as 'Internal', and consumed by another Assembly

[martinothamar]

Hi!

I think I understand why it happens, you have the source generator package installed in the AppConsole project and then have internal handlers defined in a different project right? So the generated code for invoking handlers is referring directly to the handler classes (inside AddMediator there is code that is doing AddSingleton<ICommandHandler<...>, ConcreteHandler> for example, so we need access to ConcreteHandler), which is what is causing this issue.

I think there are two ways to deal with this:

• Use public
• Ues InternalsVisibleToAttribute

I cant think of anything that we can do in the source generator to improve this at the moment, since the generated code needs to be able to reference the type where the source generator package is installed. So we have the same limitations here as in any C# code, its just a bit hidden due to being generated code. Maybe I should have some more diagnostics/warnings for this. Thanks for bringing it up.

[jeffward01]

This helps alot! Sorry for the long response back! Thank you!

It is on my 'to-do' list to build a Roslyn Analyzer for this GREAT LIBURARY that will check if handlers are marked as 'internal' and other things (that you suggest). As of now it will only check if the handlers are internal, I don't have needs yet for other features. But i would love to add some more features!

Thanks again!