Server side fetches do not calculate content-length header

[duro]

Server side fetches do not calculate content-length header

[taion]

fetch goes through a different polyfill on server v on browser - node-fetch on server v whatwg-fetch on browser (both via isomorphic-fetch). You could look at those.

[taion]

I'm actually not seeing what you report. If I run:

import {HttpStateSource} from 'marty';

HttpStateSource.removeHook('parseJSON');
const source = new HttpStateSource({});

source.post({
  url: 'http://httpbin.org/post',
  body: 'a=1'
})
  .then(res => res.json())
  .then(json => {
    console.log('state source');
    console.log(json)
  });

fetch(
  'http://httpbin.org/post',
  {body: 'a=1', method: 'POST'}
)
  .then(res => res.json())
  .then(json => {
    console.log('node-fetch');
    console.log(json)
  });

I get:

state source
{ args: {},
  data: 'a=1',
  files: {},
  form: {},
  headers:
   { Accept: '*/*',
     'Accept-Encoding': 'gzip,deflate',
     'Content-Length': '3',
     Host: 'httpbin.org',
     'User-Agent': 'node-fetch/1.0 (+https://github.com/bitinn/node-fetch)' },
  json: null,
  origin: '104.226.1.2',
  url: 'http://httpbin.org/post' }
node-fetch
{ args: {},
  data: 'a=1',
  files: {},
  form: {},
  headers:
   { Accept: '*/*',
     'Accept-Encoding': 'gzip,deflate',
     'Content-Length': '3',
     Host: 'httpbin.org',
     'User-Agent': 'node-fetch/1.0 (+https://github.com/bitinn/node-fetch)' },
  json: null,
  origin: '104.226.1.2',
  url: 'http://httpbin.org/post' }

i.e. the same behavior, with Content-Length properly supplied in both cases.

Let me know if you see further issues.

[duro]

And you tested this running the system through app.renderToString?

Becuase when I have the ran through renderToString and then insert a
before hook. The request that is passed to the before hook does not have a
content-length header.

Also, what you are sending to console log is the response headers. My issue
is that the request headers do not have a content-length.

And the API I am hitting requires that on the request.

[taion]

The httpbin.org/post endpoint echoes back the request headers - note the "Accept" settings and "User-Agent".

Your "before" hook will not see the content-length header, because the content-length header is generated after that, i.e. the before hooks are all run before we call into fetch.

[duro]

Gotcha. However, when I have fetch send route the request right back into my node API, and then I look at the request coming into that endpoint, I don't have a content-length header at the endpoint. Right now I have hacked around this by adding the header in the before hook, and this resolves the issue. That said, this feels like a hack, and something that will trip me up down the line.

[taion]

Try to see if you can reproduce the issue with node-fetch (via isomorphic-fetch) on its own. What you're describing sounds a lot like an issue there, which you should file as an issue w/the node-fetch devs if possible.