Comments (9)
I can't seem to find a helper function for converting amounts to zero-filled hex. I know this is trivial to do, but was thinking since this library is also useful to those who would be making blocks, exporting the helper function _convertAmountDecimalIntegerToHex would probably not be a bad idea?
from nanocurrency-js.
No worries, it was only ever intended to be a raw to unit one-way conversion. Your code looks good, will give it a try soon.
from nanocurrency-js.
Released! There's now the convert
function. @vano21 it can convert any value from/to hex, as requested.
from nanocurrency-js.
Just wondering, what's the point of creating the block yourself when you can use https://github.com/marvinroger/nanocurrency-js/blob/develop/DOCUMENTATION.md#nanocurrencycreateopenblocksecretkey-data--object ?
from nanocurrency-js.
Wasn't aware that the method didn't do PoW. Thanks for letting me know. Usually when I see a create block method, it's always with PoW included.
from nanocurrency-js.
Even if it is kind of optimized with the WebAssembly, it's still very expensive (time-speaking) to compute a PoW, so the library does not compute one when you create a block, you'll have to provide it yourself.
Another reason is that you might already have a PoW precomputed in cache, so you can pass it.
from nanocurrency-js.
@kilkelly considering you've 👍 this issue, and you're the author of nano-prettify, would you mind if I reuse some of your code? With the proper copyright notice, obviously!
from nanocurrency-js.
Sure thing @marvinroger , just include the MIT license and it's cool. Alternatively link it as a package to receive future bug fixes. The choice is completely up to you 💯
from nanocurrency-js.
@kilkelly there was some limitation with your code (we can only convert raw to another unit, not the other way around) and the prettify part is out of scope for this library (Numeral.js does it best), so I ended up coding the convert code myself: https://github.com/marvinroger/nanocurrency-js/blob/a7e66ab50301644fff60444a6dc784f7c5a8bb41/src/conversion.js
Thanks for the permission, though. 😉
from nanocurrency-js.
Related Issues (20)
- Block work is less than threshold HOT 1
- Can't build
- Imprementation of new state block hash generator (ADD on CLI) HOT 3
- Include createBlock() to CLI HOT 1
- Block work is less than threshold HOT 7
- Generate seed from mnemonic HOT 6
- Add new feature to help check if a indexAccount is valid HOT 3
- Feature request add schnorr MuSig N of N HOT 1
- wasm/webassembly bundle HOT 5
- Split module to have a separate module for the CLI HOT 5
- checkString in convert is useles HOT 2
- Converting 1 raw to NANO gives 0 HOT 6
- Slow performance with derivePublicKey(secretKey) HOT 4
- Feature Request : GPU Implementation HOT 1
- Validate work invalid for new PoW threshold introduced in v21 HOT 1
- Basic support - creating a send block createBlock HOT 2
- Use nano_ prefix instead of xrb_
- computeWork Minimum Threshold parameter HOT 6
- Change prefix from xrb to nano. HOT 3
- [Feature Request] Add limit to ComputeWorkParams
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nanocurrency-js.