Giter Site home page Giter Site logo

Comments (6)

epage avatar epage commented on July 29, 2024

It'd be nice if combine did a look up an showed a word or an escape sequence instead of rendering these characters.

I'd be willing to implement this, just want the go ahead first.

from combine.

epage avatar epage commented on July 29, 2024

I assume we'd either do a debug representation of the string or only do this if the string is 1 character long.

from combine.

Marwes avatar Marwes commented on July 29, 2024

Just using https://doc.rust-lang.org/std/primitive.str.html#method.escape_default and the same method of char might be good when rendering?

from combine.

epage avatar epage commented on July 29, 2024

I think the main question is handling of unicode, whether those should be escaped or not. I think most users can see and understand a unicode character but the escaped form is a
bit more mystifying (at least for this ASCII-only person)

It can be a good start though

from combine.

epage avatar epage commented on July 29, 2024

My proposal is we'd escape

  • unprintable
  • \t, \n, \r
  • Our quote character (back-quote)

I'd personally not escape \ since we are creating something for humans and I think humans would be able to understand the message.

The challenge with any of this is the impl Display for Info is for Info<T: Display, R: Display>. For non byte / char, we could end up munging people's tokens (granted, 99% of custom tokens will probably be unescaped). Though this is making me wonder how we are doing pretty printing of byte tokens which toml_edit is using.

from combine.

Marwes avatar Marwes commented on July 29, 2024

That list seems fine to me, it can always be tweaked later.

from combine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.