Comments (2)
WIP List of renames:
- SAARS to generic avatar history lookup
quickReplyYoutube
will need a rename to something likequickReplyPasteAddsTags
or something.enableMouseMenu
to reference the alt toggle option it controls
from salr-redux.
If a user has cookies disabled globally (but enabling them with per-site exception rules), I've found that the extension does not function at all - cookie settings control whether a site, and apparently even an extension, can use localStorage. Another reason to migrate it!
One other thing to plan out is how the default settings will be set. If we unwind the loading logic, we'll need to avoid the situation where the prefs are unset at the time of content script load - or, worse, on Firefox where content scripts are loaded into all existing tabs, we'll need to avoid having all of the content scripts trying to set default settings at the same time. On Legacy SALR, this was handled by the frame scripts (roughly equivalent to a content script) being loaded programmatically into pages by the main script (roughly equivalent to the background page) only after the setting situation was figured out. If all else fails, one possible solution to this is switching content script loading to be programmatically done instead of by the manifest. An advantage there would be to avoid loading content scripts into existing tabs in Firefox. It would also be possible to more easily split up the main content script into a script just for inside threads, a different script just for forum/user control panel view, etc., and only load the relevant script for that page. I'm not 100% on the internals, though, to know if checking the tab URL + programmatically loading the content scripts would be any slower, but I suppose it should still be faster than a round-trip of messages if that's the only other alternative.
Ideally, the content script can check if default settings exist/are up to date, and if so proceed immediately to load itself (nice speedup). Otherwise, it can send a message up to the background script to set the default settings, then continue loading after a slight delay when the background script responds (this case would be roughly equivalent in speed to what we have currently)
from salr-redux.
Related Issues (20)
- Hide user avatars cleanup
- Rewrite Quick Reply Checkbox Logic
- Don't display SOAP button on ignored users (no other button is there)
- Improve user notes HOT 2
- Display indicator on Quick Reply
- Display a better message for double posts
- Mozilla addon validation issues HOT 2
- Make the background script insert custom CSS HOT 1
- Setup onUpdateAvailable handler
- Split out styling code instead of looping through elements
- Wrap util.js functions into an object
- Quick reply should remember the preview is enabled when minimized
- Migrate posted-in-thread history from WebSQL to storage.local HOT 1
- Phase out the 'management' permission
- Automatic Firefox submission HOT 2
- Misclicked
- Use `!important` property for Post Highlighting styles
- SALR mouse gestures don't render correctly in Vivaldi when mouse gestures are enabled
- Reverse show avatar settings to hide avatar settings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from salr-redux.