Comments (4)
@jbooth88 seems like a bug to me. We should probably forward some additional common, non-inheritable, properties (like FontSize
) down to the nested button here.
from materialdesigninxamltoolkit.
So right now the ButtonStyle
is what is used to configured the internal buttons. If we do template bindings (which I think might be the right answer), then anything with a template binding can't be set via that style.
I am thinking we might want to just obsolete that property and use template bindings for everything as that is a more common use case. Thoughts?
from materialdesigninxamltoolkit.
@Keboo So the SplitButton.ButtonStyle
DP, in my mind, is an implementation detail. It is really only public to allow for consumers to copy-paste-modify the style and still have it compile. The same result could have been achieved without a DP, but simply a well-known resource key (this approach is used for the DatePicker
; see here), or an attached property.
The DP serves a single purpose: Mapping an MDIX SplitButton
style to the corresponding MDIX Button
style. E.g.:
MaterialDesignFlatDarkSplitButton
-> MaterialDesignFlatDarkButton
,
MaterialDesignOutlinedLightSplitButton
-> MaterialDesignOutlinedLightButton
,
etc.
Thus the DP is used to make the SplitButton
have a correct baseline-look, but should still allow for modifications via its properties as any other control. As such, I think it is fair to simply forward the "common properties" through via TemplateBindings
just like it is already doing for a number of the properties. "Common properties" probably covers any property that is intended to have a visual (and/or possibly behavioral) effect that is relevant to the SplitButton
.
from materialdesigninxamltoolkit.
Related Issues (20)
- Wrong size and wrong 'look and feel' for ToggleButton with Style="{StaticResource MaterialDesignSwitchToggleButton}" HOT 3
- Improve Snackbar feature so that multiple messages can display simultaneously HOT 2
- DataGrid Scrollbar column header not stylized
- powershell mahapps metro material design integration
- TreeListViewItem does not mark KeyEvents as handled
- DialogHost: XamlObjectWriterException - Unresolved reference 'ContentCoverBorder' HOT 3
- Need to update website HOT 1
- Can not be used under Wndows 2016 Standard HOT 3
- ColorReference does not contain any color HOT 1
- Event Handler Leak on every button click - System.Windows.VisualStateManager+<>c__DisplayClass12_0 HOT 2
- XamlParseException: InverseBoolToVisConverter - commit (#3515)
- SmartHint is clipped when FloatingScale > 1
- AutoSuggestBox crashes (demo) application
- DatePicker / TimePicker hover effect is lost when hovering calendar/time button
- cant apply any style HOT 1
- Update the wiki: Broken Links in Project Wiki HOT 3
- MVVM使用SnackbarMessageQueue导致不能被GC(内存泄露) HOT 1
- Suggest adding a multi selection combo box control
- Demo, Information Links URL not correct HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialdesigninxamltoolkit.