Giter Site home page Giter Site logo

Comments (4)

utf avatar utf commented on June 1, 2024 2

I think this is a great idea. I'd be very happy if you added this in a PR.

I think the base cclib document could also:

  1. Subclass the molecule meta task document you made (so that it has keys such as molecule and point group).
  2. Contain a dir_name key that points to the calculation directory.

from atomate2.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on June 1, 2024

Great, I'll give that a go! That's precisely what I was thinking as well. Should be easy to set up.

from atomate2.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on June 1, 2024

Regarding Point 2, it'd probably have to be a logfile_path kind of key because cclib reads specific log files rather than a directory (most, if not all, of the molecular DFT codes have just one main log file to read from). It detects the code on-the-fly, but it would need to know the file path. It's possible to rely solely on a dir_name key but that would require us to make some decisions, like "search for all files with .out, .chk, .log extensions in dir_name and parse the one with the matching extension and the newest one if there are multiple". While that's super convenient (and admittedly what I have been doing locally...), there's in principle nothing stopping me from renaming my log file .loggylog for fun.

from atomate2.

utf avatar utf commented on June 1, 2024

Fixed in #64

Thanks!

from atomate2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.