Comments (4)
@shyuep So far the wrapper is just a helper function to convert ElementProperty
featurizer in matminer to maml describer. The converted ElementProperty
is tested in compositional describers. I did only test the converted classes, not the wrapper itself. Also I have not tried the wrapper against all available featurizers in matminer, since those are currently not used. This part needs more work in future developments.
from maml.
Now the tests are failing and I am unclear why. I am not even sure what the super call is referring to when it asks for new class??
from maml.
I will look into the errors. Currently the wrapper is more of a hack to make some of the featurizers in matminer to work in maml. I dont have a more elegant solution on top of my head as of now.. we can discuss about this further.
from maml.
As for the failing tests, the issue is that we cannot use super()
outside a class without arguments.
https://docs.python.org/3/library/functions.html#super It has to be the super(some_class, self)
form.
"The zero argument form only works inside a class definition, as the compiler fills in the necessary details to correctly retrieve the class being defined, as well as accessing the current instance for ordinary methods."
from maml.
Related Issues (20)
- ValueError: could not convert string to float: ' command mindist does not exist.\n' HOT 14
- Assigning weights for each group in SNAP.train HOT 4
- Pip package contains mypy cache HOT 3
- Bowsr `minimize()` still raises IndexError
- Question about radius in BOWSR readme example HOT 7
- BayesianOptimizer.optimize() too verbose HOT 1
- A code running error HOT 1
- Training data HOT 1
- `citation.cff`
- a Code running error (Example for MTP fitting) HOT 12
- How to use potential in lammps? HOT 1
- AtomSets | Validation set splitting HOT 1
- Difference compared to FitSNAP
- The problem of model training efficiency HOT 2
- MTP example notebook (issue with imports) HOT 2
- MLIP MTP notebook HOT 6
- Running error in the mtp example in notebook HOT 1
- [Bug]: Running error in the nnp example in notebook HOT 1
- An Error occurred when I try to run GAP code in notebooks/pes/gap/example.ipynb HOT 1
- [Bug]: `Parallel`/`multiprocessing` do not work for `Describer`s
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maml.