Giter Site home page Giter Site logo

matminer wrapper has no tests about maml HOT 4 CLOSED

shyuep avatar shyuep commented on August 20, 2024
matminer wrapper has no tests

from maml.

Comments (4)

chc273 avatar chc273 commented on August 20, 2024

@shyuep So far the wrapper is just a helper function to convert ElementProperty featurizer in matminer to maml describer. The converted ElementProperty is tested in compositional describers. I did only test the converted classes, not the wrapper itself. Also I have not tried the wrapper against all available featurizers in matminer, since those are currently not used. This part needs more work in future developments.

from maml.

shyuep avatar shyuep commented on August 20, 2024

Now the tests are failing and I am unclear why. I am not even sure what the super call is referring to when it asks for new class??

from maml.

chc273 avatar chc273 commented on August 20, 2024

I will look into the errors. Currently the wrapper is more of a hack to make some of the featurizers in matminer to work in maml. I dont have a more elegant solution on top of my head as of now.. we can discuss about this further.

from maml.

chc273 avatar chc273 commented on August 20, 2024

As for the failing tests, the issue is that we cannot use super() outside a class without arguments.
https://docs.python.org/3/library/functions.html#super It has to be the super(some_class, self) form.

"The zero argument form only works inside a class definition, as the compiler fills in the necessary details to correctly retrieve the class being defined, as well as accessing the current instance for ordinary methods."

from maml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.