Giter Site home page Giter Site logo

Comments (6)

JiQi535 avatar JiQi535 commented on August 17, 2024

@thienbinh92 Can you explain more why you say "Li and transition metal layers are not arranged like POSCAR/CONTCAR"?

From my check, the CHGCAR.vasp from ProbabilityDensityAnalysis has the same atom coordinates as that of the initial structure in the AIMD snapshots you attached. I added structure.to("cif","AIMD_01.cif") to your code and compared AIMD_01.cif and CHGCAR.vasp.

from pymatgen-analysis-diffusion.

thienbinh92 avatar thienbinh92 commented on August 17, 2024

@JiQi535 Do you get "AIMD_01.cif" from vasprun.xml?
I found that the orders of elements in vasprun file (Li Co O 24 36 72) and in CHGCAR.vasp (Co Li O 36 24 72) are not the same. Here is from vasprun file:
Screenshot 0004-05-19 at 13 52 41

Here is CHGCAR.vasp generated from ProbabilityDensityAnalysis:
charge.zip

Screenshot 0004-05-19 at 13 50 08

Since the code defines incorrectly element order, may it result in wrong MSD and diffusivity?

from pymatgen-analysis-diffusion.

JiQi535 avatar JiQi535 commented on August 17, 2024

@thienbinh92 Yes, I got the AIMD_01.cif from vasprun.xml. The structure it contains should be equivalent to the initial structure of AIMD, instead of structure in CONTCAR.

With the code you provided, I generated one CHAGCAR.vasp file that does not have the problem you described.
CHGCAR.vasp.zip

I believe what you are reporting is related to a solved issue. Please update your package with git pull and pip install ., then the issue should be solved.

from pymatgen-analysis-diffusion.

thienbinh92 avatar thienbinh92 commented on August 17, 2024

@JiQi535 I am not clear on how to upgrade. So I have just uninstalled pymatgen-analysis-diffusion and re-install with the command pip install pymatgen-analysis-diffusion. It still works incorrectly.

from pymatgen-analysis-diffusion.

JiQi535 avatar JiQi535 commented on August 17, 2024

@thienbinh92 You can update it with the below codes and try again:

pip uninstall pymatgen-analysis-diffusion
git pull https://github.com/materialsvirtuallab/pymatgen-analysis-diffusion
cd pymatgen-analysis-diffusion; pip install .

@shyuep Hi Shyue Ping, I think it may be necessary to update the release on pypi, as the bug described in issue #125 has been fixed.

from pymatgen-analysis-diffusion.

thienbinh92 avatar thienbinh92 commented on August 17, 2024

@JiQi535 Thanks a lot. I downloaded and its result looks good.
PS: git pull does not work on my laptop. but git clone https://github.com/materialsvirtuallab/pymatgen-analysis-diffusion works well.

from pymatgen-analysis-diffusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.