Giter Site home page Giter Site logo

Comments (3)

MadLittleMods avatar MadLittleMods commented on July 25, 2024

πŸ‘

It seems to work just fine if you swap prop for attr.

toggleOpen = function($details, $detailsSummary, $detailsNotSummary, toggle) {
    var isOpen = $details.attr('open'),
        close = isOpen && toggle || !isOpen && !toggle;
    if (close) {
        $details.removeClass('open').attr('open', false).triggerHandler('close.details');
        $detailsSummary.attr('aria-expanded', false);
        $detailsNotSummary.hide();
    } else {
        $details.addClass('open').attr('open', true).triggerHandler('open.details');
        $detailsSummary.attr('aria-expanded', true);
        $detailsNotSummary.show();
    }
};

from jquery-details.

WebDragon avatar WebDragon commented on July 25, 2024

http://api.jquery.com/prop/ presumably there was a reason prop was used instead of attr

from jquery-details.

pthorson avatar pthorson commented on July 25, 2024

http://api.jquery.com/prop/ presumably there was a reason prop was used instead of attr

Specifically support for newer jQuery version: 3cc7fc6#diff-b76a01b9ccf8cf65939d876b7f8d079f

from jquery-details.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.