Giter Site home page Giter Site logo

Comments (7)

aureq avatar aureq commented on July 2, 2024

Also, unsure about

  • .travis.yml
  • composer.json
  • .coveralls.yml
  • libs/bower_components/jquery-ui/ui/.jshintrc
  • .editorconfig
  • libs/PiwikTracker/.git
  • .scrutinizer.yml

Let me know if safe to be removed from the release.

from matomo-package.

mnapoli avatar mnapoli commented on July 2, 2024

Hi, indeed we could, though maybe not composer.json because it might be used in the future.

Is there any reason to remove them? I wouldn't go though that trouble if they don't affect anything, especially since they may change in the future.

from matomo-package.

aureq avatar aureq commented on July 2, 2024

It's mostly for cleanliness purpose.

from matomo-package.

mnapoli avatar mnapoli commented on July 2, 2024

OK I'm in theory +1 for that, I'm just afraid of possible side effects later if things changes. E.g. I would not remove composer.json files. The rest should be OK I guess.

from matomo-package.

aureq avatar aureq commented on July 2, 2024

ok, will do, thanks.

from matomo-package.

mattab avatar mattab commented on July 2, 2024

+1 with @mnapoli point

from matomo-package.

tomduckering avatar tomduckering commented on July 2, 2024

Some of these files (i.e. bower.json) are still included in the manifest.inc.php. This seems to cause warnings in the File Integrity section of the System Check Administration page.

from matomo-package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.