Comments (1)
kegsay
commented on August 24, 2024
1
This has come up a few times. See #521 (comment)
The matchers themselves are doing the right thing and return error types. The problem is that they are typically paired with must functions, which as the package suggests, is fatal if there's a problem. It may be enough to just do as you describe:
- remove t.Fatal/Error on existing
mustfunctions - rename package to
should - add new
mustpackage which just proxies toshouldand fails if there is an error.
from complement.
Related Issues (20)
- De-emphasise and reduce the usage of `/_synapse` endpoints HOT 1
- Introduce `runtime.ForMatrixVersion` HOT 4
- Event relationship tests seem flakey HOT 1
- Hard to find test failures in CI ouput
- `TestEventRelationships` seems flakey
- `TestFederatedEventRelationships` seems flakey
- Add ability to provide blacklist file for subtests HOT 1
- `TestMediaFilenames` incorrectly tests Content-Disposition HOT 1
- Refactor how skipped tests are defined HOT 7
- Simplify internals
- Container feature detection HOT 1
- Make the Complement Client public HOT 2
- Smoke testing core features HOT 1
- Test configuration options
- Enable application service registration files to be fully editable
- Content-Type check is too restrictive in "TestRegistration/parallel/POST_{}_returns_a_set_of_flows"
- Change how server logs are dumped
- Add CI for running Complement in Podman
- Homerunner network creation seems to race deployment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from complement.