Matroska version checking is bogus

[robUx4]

Matroska version checking is bogus

[robUx4]

It works if we store the EbmlDocVersion as a pointer and have an actual instance of the version kept in memory. Maybe we can store it as a reference but we can't initialize it the ways we do not. Or maybe it needs a copy constructor in EbmlDocVersion and MatroskaProfile ?

[robUx4]

The code above doesn't work because the MatroskaProfile passed to the constructor is a temporary value. The object is destroyed after the initialization (in the static + global variables). The references point to a dead/reused memory location.

Example with this:

class A {
public:
    constexpr A(bool i) : toto(i?1:0) {}
    const int toto;
};

class B : public A {
public:
    constexpr B(bool o, bool i) : A(o), titi(i) {}
    const bool titi;
};

class holder {
public:
    constexpr holder(const A & ref)
    :myref(ref)
    {}

    const A & myref;
};

const holder holder_local(B(true, false));
constexpr const holder holder_local_expr(B{true, false});

The second constructor fails to compile because the constructor is a temporary value.

So we need to make the MatroskaProfile passed to the EbmlCallbacks constructor actual object instances kept in memory. If we can manage to turn the global EbmlCallbacks instances constexpr, it should generate build failure when not used properly, as in the example above.