Comments (2)
imho is.True(..)
already covers this and more..
from is.
I think this would compromise the ergonomics of the library by imposing ordering that you'd need to look at the arguments to know. The only two-argument method currently in the package is Equals()
, which, conveniently, does not depend on ordering. Everything else breaks down to a simple boolean clause. The only reason Equals()
even exists is because you need to guard against nil comparisons and also do some reflection to cover the most common sort of testing questions. Otherwise you could just do is.True(a==b)
What reads better?
is.True(a < b) // just boolean clauses
is.True(a>b)
or
is.Less(a, b) // which is the one that should be less?
is.Greater(b,a)
// or is it
is.Greater(a,b)
// I guess it depends on the language you speak!
You'd have to read the code to know for sure, since it no longer reads naturally. This is kind of a unique package in that the package name is part of the reading, which makes it feel light and readable, but also constrains the identifiers in expressions (IMHO for the better).
from is.
Related Issues (20)
- Additional error assertations HOT 8
- flag.Parse in init() prevents own flags in tests HOT 7
- -nocolor flag not supported by Go Test in go-1.11.4 HOT 4
- Proposal: show var names in output HOT 8
- Lines should be escaped before printing
- Add a Contains method HOT 3
- My editor thinks this is bad practice HOT 4
- New Release? HOT 1
- Ditch the indentation? HOT 1
- Small simplification
- Potential issue when running go test -json HOT 4
- Is the project still alive? HOT 5
- Proposal: value matcher interface in is.Equal HOT 2
- Release v1.5.0 HOT 2
- Proposal: Use generics to add type safety support to is.Equal HOT 10
- Revisiting `is.Equal` and the role of `reflect.DeepEqual` HOT 11
- gofmt all the things
- Issue equating zero `big.{Int,Float}`'s HOT 2
- Proposal: custom stacktrace HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from is.