Two ending tags added when "Close on End of Opening Tag" checked

[mattberkowitz]

Two ending tags added when "Close on End of Opening Tag" checked

[mattberkowitz]

I'm not able to replicate this, although I have seen it before. I added code in 0.5.0 which should have stopped it, I added code that removed the event before adding it so that it would get bound multiple times.

What settings do you have checked? What other modules have you added? I first saw this bug when I started working on another module with a similar event setup that was making autoclose-html bind it's event twice.

[yuchi]

I’m pretty sure this is a double event binding. The module has ‘started twice’.

[mattberkowitz]

@yuchi,
There was no question that that's what's happening. The issue is why. In 0.5.0, I changed the code where the event is bound to:

editorView.editor.buffer.off('changed',fcn);
editorView.editor.buffer.on('changed', fcn);

This should prevent the event from ever being bound a 2nd time

[yuchi]

If fcn is another function then that .off will never work, of course. What I think is that the culprit is the dev-reload of plugins. You could try to log something in the closure which creates fcn. I think it is executed twice. IMHO.

[mattberkowitz]

I was able to reproduce by spamming the "Close on end of opening tag option." If you reopen ember, or ctrl+opt+cmd+L to reset it should resolve the problem for now. I'll fix it in code in the next release

[mattberkowitz]

Sorry for taking so long for a proper fix to this. I just released 0.6.0 which includes a fix for this issue. Please let me know if you still encounter problems

[dushaun]

Hi There,

Using Atom 1.0.2 with autoclose-html 0.18.0 and I've suddenly come across the doubling up again. Was the Error truly fixed?