Comments (7)
I'm not able to replicate this, although I have seen it before. I added code in 0.5.0 which should have stopped it, I added code that removed the event before adding it so that it would get bound multiple times.
What settings do you have checked? What other modules have you added? I first saw this bug when I started working on another module with a similar event setup that was making autoclose-html bind it's event twice.
from autoclose-html.
I’m pretty sure this is a double event binding. The module has ‘started twice’.
from autoclose-html.
@yuchi,
There was no question that that's what's happening. The issue is why. In 0.5.0, I changed the code where the event is bound to:
editorView.editor.buffer.off('changed',fcn);
editorView.editor.buffer.on('changed', fcn);
This should prevent the event from ever being bound a 2nd time
from autoclose-html.
If fcn
is another function then that .off
will never work, of course. What I think is that the culprit is the dev-reload of plugins. You could try to log something in the closure which creates fcn
. I think it is executed twice. IMHO.
from autoclose-html.
I was able to reproduce by spamming the "Close on end of opening tag option." If you reopen ember, or ctrl+opt+cmd+L to reset it should resolve the problem for now. I'll fix it in code in the next release
from autoclose-html.
Sorry for taking so long for a proper fix to this. I just released 0.6.0 which includes a fix for this issue. Please let me know if you still encounter problems
from autoclose-html.
Hi There,
Using Atom 1.0.2 with autoclose-html 0.18.0 and I've suddenly come across the doubling up again. Was the Error truly fixed?
from autoclose-html.
Related Issues (20)
- Cancel extra tab for certain block tags (enhancement)
- Extra > before and after opening/closing tag HOT 1
- explorer.exe HOT 1
- More '>' signs after each disable/enable HOT 1
- HTML + tab
- How to install this package? HOT 1
- Only works when typing > on the opening tag, should also work on </ for the closing
- Do not close if there is already a matching close tag
- Never close elements doesn't work HOT 4
- The autoclose keybind of ">" also types a ">" HOT 6
- Closes tag after => in jsx
- Extra Indentation on close tag HOT 9
- Unnecessary Indent HOT 1
- Make Never Close Elements Self Closing function HOT 2
- problem with auto complete HTML HOT 10
- not doing anything at all HOT 3
- Deprecated selector in `autoclose-html/styles/autoclose-html.less`
- When typing, the key '#' gets replaced by '>' HOT 1
- Opening and closing tags should enclose selection
- Autoclose closes "never-close" tags [Issue when loading configs] HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autoclose-html.