Comments (6)
hmm. The nature of some of these changes, I am not sure they are correct. Did
you
verify the unit tests still pass (no new failures were created)?
For example, you changed
(?=\n+|\Z)
to
$
The above is a positive lookahead, whereas the below is a simple "match end of
line".
At the very least, I think it would need to be:
(?=$)
And even then, deviating too far from the regexes in the markdown.pl v1.0.1 and
markdown.pl v1.0.2b8 is IMHO not a good idea -- at least not without a VERY good
reason. (See my DeTab() changes for one time that can happen..)
Original comment by [email protected]
on 28 Dec 2009 at 6:49
from markdownsharp.
get latest -- I added a crc-16 to the output HTML file generation in
GenerateTestOutput("mdtest-1.1"). Confirm that no *.xxxx.actual.html files
change --
the xxxx is the crc-16 of that file -- between the version you get from source
control, and the version with your proposed regex changes.
Original comment by [email protected]
on 28 Dec 2009 at 8:52
from markdownsharp.
can you send a new patch of *just* the changes you are proposing here?
The other patch has a bunch of unrelated changes..
Original comment by [email protected]
on 29 Dec 2009 at 2:47
from markdownsharp.
Hi Jeff,
This change isn't as dramatic as it was before the compiled flags were added,
but I
think it cleans up some of the Regex logic and uses some built in processors
for the
RegexOptions.Multiline instead of doing the start and end lines manually.
Nick
Original comment by nberardi
on 29 Dec 2009 at 3:01
Attachments:
from markdownsharp.
Thanks. I grabbed the patch, applied it, and tested.
Decline for two reasons:
1) that block is about to change majorly when I pull across the new HTML block
detection in markdown.pl 1.0.2b8 (fixes the two test failures in
/mdtest-1.1-alt)
2) I'm not a big fan of changing the regexes from the original Perl versions
unless
there is a really COMPELLING reason to do so. I don't see any performance
benefit in
the benchmarks, or additional correctness from making these changes.. so
they're just
change for the sake of change in an area where it's a bad idea to have change --
because we want to be able to fully sync with the Perl version whenever we can.
Original comment by [email protected]
on 29 Dec 2009 at 4:14
- Changed state: WontFix
from markdownsharp.
Agreed. There seemed to be a performance gain, but it has been mitigated by
changes
since I submitted this.
Also I was unaware that markdown (perl version) was still being actively
developed. So
(2) makes alot of sense to me now. I will keep that in mind for any future
patches I
submit.
Original comment by nberardi
on 29 Dec 2009 at 4:39
from markdownsharp.
Related Issues (20)
- title element not escaped
- Problem with auto email links
- Add link to Pagedown on the project home page. HOT 1
- Allow to set base url for relative url
- URL detection bug for URLs that contain parentheses
- f3973492a27c breaks ConfigTest.TestEncodeProblemUrlCharacters
- Enable EmailEncoding as an option HOT 1
- <code> tags are rendered inside of <pre> for code blocks
- Add option to avoid Paragraph around single element
- Support Pandoc Extensions to Markdown
- Add Strikethrough
- Have the option to add a prettify class name to the <pre> tags
- URL: Support protcol-relative URLs
- Auto-URLs are breaking with any url that has an underscore HOT 1
- Strange <p> tag placement
- Unit test error: MarkdownSharpTests.ConfigTest.TestEncodeProblemUrlCharacters HOT 1
- AutoNewlines set through MarkdownOptions replaces EOL with <br instead of <br />
- Add SkipCodeBlocks Option HOT 1
- Migrate to GitHub! HOT 1
- Sponsor an official nuget package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdownsharp.