Comments (3)
Currently this is intentional as the installation uses the same base directory of .foundryup
. If we want to avoid overwriting one another while also ensuring devs can execute the desired binary (between upstream and foundry-zksync
) we would need to rename the binaries away from forge
and cast
. We want to keep the namespace the same, but perhaps we can introduce a forge
version manager to switch between the two easily enough.
I will leave this open for now, but this is currently intentional.
from foundry-zksync.
@dutterbutter I'm also facing this issue. After running foundryup
i rebuilt zksync-foundry
to try to get it to re-override forge
and it wouldnt do so. I ended up using target/release/forge build --zksync
to use this tool. Is this expected? If so I think it would be great to add it to the getting started
docs somewhere!
from foundry-zksync.
@dutterbutter The installation does not override when we set custom paths and aliases, but this adds a lot of overhead - both in installation and scripts for remote repos.
For engineers using both foundry
and foundry-zksync
this is cumbersome.
How much of an effort do you reckon it is to alter the base directory to .foundry-zksync
and similarly renaming binaries by appending a -zkync
?
This would make using the tools in such a way much more explicit.
I'm going to do manually set binary installation directory, and use aliases locally and explicitly define paths in scripts for collaborators but ideally this would be avoided.
from foundry-zksync.
Related Issues (20)
- Unable to deploy contract with big factory deps on zkSync Era mainnet HOT 9
- "./install-foundry-zksync" not working HOT 20
- `forge coverage --via-ir` fails with stack too deep HOT 1
- Reading value that was deleted in a mapping causes panic HOT 3
- Getting an error when running ./install-foundry-zksync HOT 10
- Unable to deploy using create2 factory HOT 4
- Using `vm.writeFile` throws `EvmError: Revert` HOT 3
- Error installing foundry-zksync HOT 1
- Failure building forge
- Empty forked state for `vm.createSelectFork` HOT 1
- Contract deploy bug in fork test HOT 2
- build --sizes does not work properly (false negative error code) HOT 1
- cast etherscan-source seems to not work HOT 4
- EvmError: InvalidOperandOOG when called SystemContractsCaller.systemCallWithReturndata HOT 4
- Fuzz Test Failure in Counter.t.sol on zkSync with Foundry in Windows/WSL HOT 1
- vm.recordLogs does not record events emitted by calls
- Docs installation guide does not work HOT 1
- --zksync flag causes invariant tests to hang HOT 3
- Cargo install from git is failing to build HOT 1
- Installation verification failed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foundry-zksync.