Giter Site home page Giter Site logo

Comments (3)

dutterbutter avatar dutterbutter commented on August 21, 2024 3

@PatrickAlphaC

Currently this is intentional as the installation uses the same base directory of .foundryup. If we want to avoid overwriting one another while also ensuring devs can execute the desired binary (between upstream and foundry-zksync) we would need to rename the binaries away from forge and cast. We want to keep the namespace the same, but perhaps we can introduce a forge version manager to switch between the two easily enough.

I will leave this open for now, but this is currently intentional.

from foundry-zksync.

hensha256 avatar hensha256 commented on August 21, 2024

@dutterbutter I'm also facing this issue. After running foundryup i rebuilt zksync-foundry to try to get it to re-override forge and it wouldnt do so. I ended up using target/release/forge build --zksync to use this tool. Is this expected? If so I think it would be great to add it to the getting started docs somewhere!

from foundry-zksync.

NouDaimon avatar NouDaimon commented on August 21, 2024

@dutterbutter The installation does not override when we set custom paths and aliases, but this adds a lot of overhead - both in installation and scripts for remote repos.

For engineers using both foundry and foundry-zksync this is cumbersome.

How much of an effort do you reckon it is to alter the base directory to .foundry-zksync and similarly renaming binaries by appending a -zkync?

This would make using the tools in such a way much more explicit.

I'm going to do manually set binary installation directory, and use aliases locally and explicitly define paths in scripts for collaborators but ideally this would be avoided.

from foundry-zksync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.