Giter Site home page Giter Site logo

Comments (8)

marianunez avatar marianunez commented on September 15, 2024 1

Opened a PR for this: #23

from mattermost-plugin-custom-attributes.

aaronrothschild avatar aaronrothschild commented on September 15, 2024

@DHaussermann :+7:

from mattermost-plugin-custom-attributes.

marianunez avatar marianunez commented on September 15, 2024

I'm surprised about that because it was showing like this for my PR #18 that introduced this feature:

Will take a look again on latest master to see if there was anything that was changed there that could have affected that.

from mattermost-plugin-custom-attributes.

marianunez avatar marianunez commented on September 15, 2024

@DHaussermann I'm still seeing the icon as expected with the latest of the plugin and WebApp:

Screen Shot 2020-02-28 at 12 25 43 PM

Any other specifics on how to reproduce this?

from mattermost-plugin-custom-attributes.

DHaussermann avatar DHaussermann commented on September 15, 2024

@marianunez interesting. Is it possible to DM me the server and credentials so I can try and isolate this?

from mattermost-plugin-custom-attributes.

DHaussermann avatar DHaussermann commented on September 15, 2024

This issue repros on Windows but not Mac.
Seems like we don't serve an image but rather rely on something provided by a font the OS has.

DeleteIcon

from mattermost-plugin-custom-attributes.

aaronrothschild avatar aaronrothschild commented on September 15, 2024

@asaadmahmood Do you have any idea what we should do here? Should we use a trash can instead? SVG needed if it's not a system graphic.

from mattermost-plugin-custom-attributes.

asaadmahmood avatar asaadmahmood commented on September 15, 2024

Yes, a trash can would be good.
We can use the trashcan like:
<i class="fa fa-trash"></i>

from mattermost-plugin-custom-attributes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.