Custom Attributes should not be shown, if post is from webhook

[mattermost-community]

Custom Attributes should not be shown, if post is from webhook

[hanzei]

@nathanaelhoun The webapp uses the check for additional data like attaching the text This post was created by an integration from . This should only be shown (AFAIK) when the user name actually gets overwritten. Let's keep the scope of this ticket to only fixing the issue that custom attributes if facing and don't change the behavior on the webapp.

[sudiptog81]

I want to work on this issue, can anyone refer to the relevant files?

[hanzei]

Thanks @sudiptog81 👍 https://github.com/mattermost/mattermost-plugin-custom-attributes/tree/master/webapp/src/components/user_attribute does contain the files for the profile popover.

[sudiptog81]

@hanzei I think we can reuse https://github.com/mattermost/mattermost-redux/blob/2b68c18adcccfe58ad8b58d682b341b97929d058/src/utils/post_utils.ts#L32 and return null here https://github.com/mattermost/mattermost-plugin-custom-attributes/blob/master/webapp/src/components/user_attribute/user_attribute.jsx#L28. However, we would need to access the Post Object.

[hanzei]

Yes, that would also work 👍

[jasonblais]

Opening back up for grabs. You can find a PR that started work on this ticket at #57

[nathanaelhoun]

Hi! I'm interested to take this one. If I understood well the discussion in #57, the problem is that we don't have access to the fromWebhook property in the plugin. I have tested some changes in the webapp making the fromWebhook accessible in the plugin.

Is this a correct way to proceed? If so, I will submit PRs in webapp and plugin :-)

[hanzei]

@larkox Thanks for taking a look @nathanaelhoun 👍 Adding fromWebhook to the ProfilePopoverProps seems reasonable to me. Why did you also touch the code in render()?

[nathanaelhoun]

Why did you also touch the code in render()?

@hanzei The webapp used the trick of const haveOverrideProp = this.props.overwriteIcon || this.props.overwriteName; to know if the popover was from a webhook. It's why I proposed to change the webapp as well, but I can revert these changes 😄