Giter Site home page Giter Site logo

Comments (8)

Szymongib avatar Szymongib commented on June 19, 2024 3

Hey @imskr, there were some issues with scripts installing tooling. You can rebase with master and try again.

from mattermost-operator.

imskr avatar imskr commented on June 19, 2024

Can I work on this @Szymongib ?

from mattermost-operator.

Szymongib avatar Szymongib commented on June 19, 2024

Sure @imskr :)
Let me know if you have any questions.

from mattermost-operator.

imskr avatar imskr commented on June 19, 2024

@Szymongib When setting up this repo locally and running command make build-image kind-load-image deploy I get following error:

go: added sigs.k8s.io/yaml v1.2.0
mv: rename /Users/shubhamkumar/go/src/github.com/mattermost/mattermost-operator/bin/controller-gen to /Users/shubhamkumar/go/src/github.com/mattermost/mattermost-operator/bin/controller-gen-v0.7.0: No such file or directory
make: *** [/Users/shubhamkumar/go/src/github.com/mattermost/mattermost-operator/bin/controller-gen] Error 1

from mattermost-operator.

imskr avatar imskr commented on June 19, 2024

@Szymongib I have a question?

  1. Can we directly call LaunchMattermostUpdateJob function here ? so that the owner reference gets added

from mattermost-operator.

Szymongib avatar Szymongib commented on June 19, 2024

When setting up this repo locally and running command make build-image kind-load-image deploy I get following error:

Does the bin directory exists? You might want to try creating it, but not sure if that will help, will need to look into it.

Can we directly call LaunchMattermostUpdateJob function here ? so that the owner reference gets added

I do not think so. The Create function is called in multiple different places for multiple different objects, we would not like to lunch a job each time it is called. You could however use the ResourceHelpers Create function to create and update job instead of directly using the Client here

from mattermost-operator.

imskr avatar imskr commented on June 19, 2024

When setting up this repo locally and running command make build-image kind-load-image deploy I get following error:

Does the bin directory exists? You might want to try creating it, but not sure if that will help, will need to look into it.

No it doesn't inside root of repo

Can we directly call LaunchMattermostUpdateJob function here ? so that the owner reference gets added

I do not think so. The Create function is called in multiple different places for multiple different objects, we would not like to lunch a job each time it is called. You could however use the ResourceHelpers Create function to create and update job instead of directly using the Client here

Thanks

from mattermost-operator.

imskr avatar imskr commented on June 19, 2024

Thanks @Szymongib

from mattermost-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.