Do not return errors from reconciliation when waiting for update job

[mattermost]

Do not return errors from reconciliation when waiting for update job

[gabrieljackson]

Hey @imskr, yeah that seems like a fairly reasonable implementation.

For (2), we would want to take the returned bool and have the reconciler queue up another reconcile loop after a certain specific delay. Something like 5-10 seconds seems about right to me. The idea here is we don't want to have the operator think there was too many errors and fall into delayed reconciliation checks which it will do at a certain threshold.

[imskr]

Can I work on this?

[imskr]

Thanks @Szymongib After reading the description I have some thoughts:

1. We can return bool alongside error in updateMattermostDeployment and we can maybe return true here after checkUpdateJob

2. Inside Reconcile() I have to use the true bool from above to somehow stop from reconciling.

Am I right?

[Szymongib]

Inside Reconcile() I have to use the true bool from above to somehow stop from reconciling.

Yes, the general idea sound right, we might however consider returning some struct representing the status from checkMattermost instead of simple boolean for better clarity.

[Szymongib]

Sure @imskr, I will assign you.