Giter Site home page Giter Site logo

Comments (5)

Szymongib avatar Szymongib commented on July 18, 2024 1

Thanks for reporting the issue.

I think if we provide the ability to override the image I can see people wanting to modify the command also.
If we would like to go with that, maybe we could take the following approach:

apiVersion: installation.mattermost.com/v1beta1
kind: Mattermost
...
spec:
  database:
    readinessCheck:
       initContainers: [Full Containers deffinition here allowing user to override everything (in Go type []v1.Container)]

The readinessCheck is just random name I came up on the spot and we can think of something better, the point is that it will allow user to customise the check further.

In case the readinessCheck would be provided by the user, the operator would not inject the default init containers.

What do you think about this approach? @mjnagel @gabrieljackson

from mattermost-operator.

mjnagel avatar mjnagel commented on July 18, 2024

That makes sense to me, allowing more customization would be better for future-proofing I'd imagine since someone else could come along and want to customize a different piece of this (command as you mentioned definitely would be a big one).

from mattermost-operator.

mjnagel avatar mjnagel commented on July 18, 2024

Any progress on this/is help wanted implementing this? This is something we definitely want so that we can override the image (although the additional flexibility to override the entire init container may be nice as well).

from mattermost-operator.

gabrieljackson avatar gabrieljackson commented on July 18, 2024

Hey @mjnagel, sorry about the delay on this.

Any progress on this/is help wanted implementing this?

Yes, this is exactly the sort of feature request we would love to have community engagement on. It has been opened as a help wanted ticket and we will add it ourselves in the coming weeks if there are no volunteers.

from mattermost-operator.

Szymongib avatar Szymongib commented on July 18, 2024

As discussed, picking this one up due to this feature being a higher priority and lack of interest from the community side.

from mattermost-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.