Yamls are wrong

[mattermost]

Yamls are wrong

[Szymongib]

Hey, thanks for reporting the issue.

The namespaces are populated thanks to -n mattermost-operator. I think there used to be some idea to make namespace configurable that is why the metadata.namespace was not set, but indeed it does not make much sense due to the Cluster Rolebinding subject.

I will fix it with the upcoming release.

[felix-dpg]

Yes, is not make sense because there are resource that you cant apply the namespace if you follow the way in that you apply the mattermost yamls.

[felix-dpg]

Hey:

Also the yamls of CRD are...wrong??

Problem:

In the docs say that learn more about CRD here:

https://github.com/mattermost/mattermost-operator/blob/master/config/crd/bases/installation.mattermost.com_mattermosts.yaml

In the yaml doc CRD, there is a different definition for ingress option, also in this same doc say:

description: 'IngressAnnotations defines annotations passed to the Ingress associated with Mattermost. Deprecated: Use Spec.Ingress.Annotations.'

But in the main page of your k8s installation the file that contain CRDs is different, and of course, the ingress definition is different: Here, need to be spec.ingressAnnotations instead of Spec.Ingress.Annotations.

https://raw.githubusercontent.com/mattermost/mattermost-operator/master/docs/mattermost-operator/mattermost-operator.yaml

              ingressAnnotations:
                additionalProperties:
                  type: string
                type: object
              ingressName:
                description: IngressName defines the name to be used when creating
                  the ingress rules
                type: string

Other question is that why mattermost does not give us the possibility defining Kind: Mattermost to select the servicetype, NodePort for example, instead of the need to create the services by ourself.

[Szymongib]

The CRDs here https://raw.githubusercontent.com/mattermost/mattermost-operator/master/docs/mattermost-operator/mattermost-operator.yaml are aligned with the latest released version while those https://github.com/mattermost/mattermost-operator/blob/master/config/crd/bases/installation.mattermost.com_mattermosts.yaml contain changes from master.

When we do the release the whole installation file is generated from other files so that is when they will be updated.

[felix-dpg]

So, why not allign the CRD docs with the main docs if at the end is the release that we will apply?

[Szymongib]

Sorry, not sure if I follow your suggestion, do you mean updating documentation to link to https://raw.githubusercontent.com/mattermost/mattermost-operator/master/docs/mattermost-operator/mattermost-operator.yaml instead of https://github.com/mattermost/mattermost-operator/blob/master/config/crd/bases/installation.mattermost.com_mattermosts.yaml ?

[felix-dpg]

I mean update the CRD docs with the same CRDs that appear here https://github.com/mattermost/mattermost-operator/blob/master/config/crd/bases/installation.mattermost.com_mattermosts.yaml.

[Szymongib]

Yeah, as I mentioned it happens during the release as the old Operator would not understand changes in the CRD.