Giter Site home page Giter Site logo

Comments (4)

Szymongib avatar Szymongib commented on July 18, 2024 1

Hey @mjnagel, thanks for reporting the issue.

I have worked with Istio before so I am aware of this behavior.

We are thinking of refactoring CR to define Service customization in a similar way as we did with Ingress (similarly to your second proposition) as we have requests for some other customizations. Not sure when we will be able to go about it as we would probably like to do it in the new CR version so that we can break compatibility for some features like useServiceLoadbalancer.

For your case tho, I see that there is another way of defining the protocol, not just by port name but with the use of appProtocol on a Service port as mentioned here.

I think we could do that just by modifying the Service created by the Operator and holding off with specifying additional customization for now.

Let me know if that would work for you.

from mattermost-operator.

mjnagel avatar mjnagel commented on July 18, 2024 1

Ah good catch. I can test that out today and open a PR with the appProtocol assuming it looks good on my end.

from mattermost-operator.

mjnagel avatar mjnagel commented on July 18, 2024

@Szymongib adding appProtocol worked perfectly in my dev environment, opened #267 to add that 😄 . I put it on both services, which I think is correct although I've never used the LB one in my testing.

from mattermost-operator.

Szymongib avatar Szymongib commented on July 18, 2024

Awesome! Thanks a lot @mjnagel we will have a look!

from mattermost-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.