Giter Site home page Giter Site logo

Comments (5)

enoldev avatar enoldev commented on May 25, 2024 1

Ok, I see flags as Subscription fields a good idea. It should also be more efficient than having it in an array of strings as we won't have to iterate just to check if the flag is set. Maybe another struct SubscriptionFlags could be included.

Thanks @hanzei!

from mattermost-plugin-github.

enoldev avatar enoldev commented on May 25, 2024

I'd like to work on this! Thanks.

from mattermost-plugin-github.

hanzei avatar hanzei commented on May 25, 2024

That's awesome, thanks @enolal826 🎉

from mattermost-plugin-github.

enoldev avatar enoldev commented on May 25, 2024

Hello!

Two aspects:

  1. Since currently no flags are supported, I've thought it'd be more convenient for the Subscription struct to have a "flags" field. What do you think?
  2. As of now, when subscribing there is just one field "features" supported and is supposed to be a comma-separated string, but other features are also considered:
    features = strings.Join(parameters[1:], " ")

It means that for the command
/github subscribe owner/repo pulls,issues anotherThing
both "pulls,issues" and "anotherThing" would be inserted in the "feature" field. I don't know if this is something expected

Thanks!

from mattermost-plugin-github.

hanzei avatar hanzei commented on May 25, 2024
  1. I would like to have the "flags" as boolean fields of in the Subscription struct. This way we make sure that we do the parsing of the input only once and then have all data in the struct
  2. That is not expected. "anotherThing" should not go into Features.

Let me know, if this resolves your questions.

from mattermost-plugin-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.