Comments (5)
Ok, I see flags as Subscription fields a good idea. It should also be more efficient than having it in an array of strings as we won't have to iterate just to check if the flag is set. Maybe another struct SubscriptionFlags could be included.
Thanks @hanzei!
from mattermost-plugin-github.
I'd like to work on this! Thanks.
from mattermost-plugin-github.
That's awesome, thanks @enolal826 🎉
from mattermost-plugin-github.
Hello!
Two aspects:
- Since currently no flags are supported, I've thought it'd be more convenient for the Subscription struct to have a "flags" field. What do you think?
- As of now, when subscribing there is just one field "features" supported and is supposed to be a comma-separated string, but other features are also considered:
features = strings.Join(parameters[1:], " ")
It means that for the command
/github subscribe owner/repo pulls,issues anotherThing
both "pulls,issues" and "anotherThing" would be inserted in the "feature" field. I don't know if this is something expected
Thanks!
from mattermost-plugin-github.
- I would like to have the "flags" as boolean fields of in the
Subscription
struct. This way we make sure that we do the parsing of the input only once and then have all data in the struct - That is not expected. "anotherThing" should not go into
Features
.
Let me know, if this resolves your questions.
from mattermost-plugin-github.
Related Issues (20)
- Include explanation of `/setup` command in README HOT 2
- `Unable to find manifest for extracted plugin` when using `make deploy` HOT 1
- [Request] Ability to hide entries (especially PRs) from daily summary
- Improve performance of Create Issue modal repository selector HOT 3
- Code previews only work for commit hashes, not for branches
- [Enhancement Proposal] Delaying Draft Pull Request Notifications until Marked as 'Ready for Review' HOT 4
- Pull Request Reviews are not posted. HOT 1
- Code in Pull Request code blocks is broken on Mattermost
- unusable links in plugin messages HOT 2
- User not receiving DM notifications. Had to manually run `notifications on` slash command to re-enable HOT 2
- Mattermost Github Plugin will not start HOT 4
- No pr review notifications if my team was assigned as reviewer
- Creating a test issue for GitHub board.
- Explain in docs not to fill out the `Enterprise Base URL` config setting if the GH Enterprise instance is hosted on GitHub's domain HOT 2
- Clarify subscribe message when there is no webhook found
- Subscriptions not creating posts for reopening PRs
- Push events: option to show commit author instead of committer HOT 6
- Feature Request: Subscribe to GitHub Action workflow failures HOT 4
- Feature Request: Subscribe to release events
- The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.