Comments (9)
@jfrerich is this something I can help with ?
from mattermost-plugin-welcomebot.
@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the config.json
settings the user used for the welcomebot settings ?
from mattermost-plugin-welcomebot.
@jfrerich attached a message from @aaronrothschild
Hmmm...that's an interesting situation. @dylan.haussermann do we test for this at all?
This seems like a good new issue: restrict welcomebot messages to "full" users and ignore "guest" users (add an option in config to observe this behavior optionally)
from mattermost-plugin-welcomebot.
@jfrerich attached a message from @aaronrothschild
@jason.frerich or @shota.gvinepadze I suspect the plugin bot has permissions to add the user to any channel (and does so) - without taking into account they are a guest account.
from mattermost-plugin-welcomebot.
@jfrerich attached a message from @aaronrothschild
cc @katie.wiersgalla Just a heads up about this edge case with regards to Guest accounts and welcomebot inviting the users to join a channel on the server (which they probably shouldn't be presented with). When they click the button, they get added to channels on the server. I suspect this is unexpected behavior. It's not "broken" per se - the plugin has the ability/permission to add users to any channel. We'll triage it as a bug/story, but it's not high priority because Welcomebot is not available to Cloud customers currently.
from mattermost-plugin-welcomebot.
@jfrerich attached a message from @aaronrothschild
I agree there should be a configuration to disable/enable ignoring a guest user. For now, let's address the main issue of in a private MM instance, guests should not be invited to welcomebot rules. If it's an open instance, then users can receive welcomebot messages and get added to room. .
I could see this gettingmore complex (ie: For guests, show them THIS rule instead, etc.)....but let's start simple.
from mattermost-plugin-welcomebot.
@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the
config.json
settings the user used for the welcomebot settings ?
@maisnamraju, are you having issues replicating the case where a guest account is getting invited via the welcomebot rules? I believe the ask for this particular ticket is to add the restriction that guest user accounts to not get invited. @aaronrothschild, is that correct?
from mattermost-plugin-welcomebot.
@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the
config.json
settings the user used for the welcomebot settings ?@maisnamraju, are you having issues replicating the case where a guest account is getting invited via the welcomebot rules? I believe the ask for this particular ticket is to add the restriction that guest user accounts to not get invited. @aaronrothschild, is that correct?
Yes, I wanted to replicate this bug. Can you lay out the steps I can use to replicate this issue ?
from mattermost-plugin-welcomebot.
@jfrerich sorry I haven't been checking up on this one, but could you show me how I could replicate this condition ?
from mattermost-plugin-welcomebot.
Related Issues (20)
- [Request] Support adding to channels based on groups, not just teams HOT 2
- Neither the preview comand nor welcome message works if team name has a space in it HOT 4
- v1 HOT 1
- Implement plugin settings in admin console HOT 11
- Add example usage of Include Guest to read me HOT 2
- config.json content erased and no message saved HOT 2
- Do not write private messages HOT 1
- mmomni.yml vs config.json
- error occurred while processing greeting for team server: failed to query team server: GetTeamByName: Unable to find the existing team HOT 1
- Duplicate categories are created if new members are assigned to channels and channels are assigned to categories HOT 6
- Setup via Docker Envrionment Variables HOT 3
- Automatically add users to all channels HOT 1
- Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin
- Action integration error HOT 3
- getting the error while running the *make* Command for welcome-bot HOT 10
- Action button faulty HOT 3
- Restricted Direct Message Setting in Server Breaks WelcomeBot
- Welcome channel message visibil for all channel members? HOT 2
- Can't use {{.UserDisplayName}} in channel welcome message HOT 2
- Error submitting welcomebot form: "We could not decode the action" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-welcomebot.