Notifications not working in web client on Mac

[MJegorovas]

Notifications not working in web client on Mac

[hmhealey]

Thanks for the feedback, @MJegorovas! There's definitely a bunch of stuff we should look at here.

It sounds like there's a few different things going on here:

1. On Safari, we're failing to request the user's permission correctly. That should've been fixed in 9.10.0 by #26849 which would make it so that the user is prompted for permission before receiving a new message. Do you see the bar asking for that permission?

   If not, could you open a new tab, open the JS console, and check what the value of Notification.permission is?

2. On Firefox, the notification not appearing in the Notification Centre is an odd one. Looking at the code, I think the issue is actually because of some very old logic for automatically closing notifications back before that was controlled by the OS. We should be good to just remove that logic now.

3. On Firefox, I think the doubled up notification sound is a long-running UX issue. Firefox doesn't let us disable the system sound, so we'd have either have to have the user disable their OS notification sound manually or disable the MM notification sound.

---

@abhijit-singh Any suggestion on how we might fix the third one? To summarize the above, if you have desktop notification sounds enabled on Firefox on Mac, you head both the MM notification sound as well as one from MacOS

[amyblais]

https://mattermost.atlassian.net/browse/MM-59315

[hmhealey]

Because I like linking things, here's a ticket for the second issue I listed above (https://mattermost.atlassian.net/browse/MM-59404) and for the third one (https://mattermost.atlassian.net/browse/MM-59403).

I need some more details on the first one before I can look at fixing it

[MJegorovas]

On Safari, we're failing to request the user's permission correctly. That should've been fixed in 9.10.0 by #26849 which would make it so that the user is prompted for permission before receiving a new message. Do you see the bar asking for that permission?

Yes I do, this is the behaviour after granting it. Had more comments, but I see that in the issue you've got everything figured out.

[hmhealey]

Thanks for confirming. Given we're finding that there's more issues here than we'd expected, I'm glad that that seems to cover everything you saw on Safari 😅

[hmhealey]

Okay, to summarize the issues reported here:

1. MM notification sounds overlapping OS ones (MM-59315) - This is not fixed yet, but we're talking to the UX team about how that should be handled in cases where we can't prevent the OS notification sound from playing.
2. Notifications not appearing in notification center (MM-59404) - This is fixed in v10.0 coming in September. The fix has already been deployed to https://community.mattermost.com.
3. Notifications not working in Safari (MM-59416) - This is fixed in v9.10.1 coming soon and v9.11 coming in August. This fix has also been deployed to our community server.

Because the more critical issues with notifications just not working have been fixed, I'm going to close this issue, but feel free to reopen this if those issues reoccur.

Thanks again for reporting this! We need to get someone on the team to use Safari as their regular browser so we can catch this sort of issue sooner