Giter Site home page Giter Site logo

Comments (4)

matthiasmullie avatar matthiasmullie commented on June 17, 2024 1

Haha, don't worry about it; no offense taken - I read nothing crass in there, just a factual statement that this particular thing has become irrelevant for you.
(And I mean, why would it even still be relevant almost 4 years later :D)

from scrapbook.

matthiasmullie avatar matthiasmullie commented on June 17, 2024

My sincere apologies for this absurdly late reply.

Yes, it would make a lot of sense for this feature to be implemented, and I would very much welcome any pull request to implement it.

However, back when originally implementing the current stampede protection implementation, I did consider this approach as well. And there was a reason I didn't end up also implementing this.

I can't remember the exact reasons, though. Perhaps something about it simply didn't fit the interface, perhaps it had something to do with cross-adapter or PHP/HHVM versions compatibility, perhaps something else entirely. I'm sorry, but I can't remember.

If (so long after you originally submitted this) you still have an interest in pursuing this and think it is feasible to implement, I would be very interested to receive of pull request, or cooperate to help see this through!

from scrapbook.

mindplay-dk avatar mindplay-dk commented on June 17, 2024

I haven't used PHP in years. Feel free to close this. 😅

from scrapbook.

mindplay-dk avatar mindplay-dk commented on June 17, 2024

I hope this didn't come off crass like I was trying to imply something about PHP or your library.

For the record, your library worked great! The company I worked at are still using it and afaik they've always been very happy with that choice. Just that I haven't personally been working with PHP in the last couple of years. ☺

from scrapbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.