Failed to minify constants/index.js when build with CRA

[matthieulemoine]

Failed to minify constants/index.js when build with CRA

[MatthieuLemoine]

@ydatech CRA uses Webpack@^3 which is bundled with a version of UglifyJS that does not support ES6. Webpack@^4 is bundled with a new version of UglifyJS that can parse ES6.

Four solutions here :

• Waiting for https://github.com/facebook/create-react-app/pull/4077 to be merged
• Add a transpilation step with Babel in electron-push-receiver
• Eject from CRA and update your webpack config with an imported version of UglifyJS (not the bundled one)
• Eject from CRA and update your webpack config to make it transpile electron-push-receiver

[ydatech]

@MatthieuLemoine
I have fixed the issue by moving constants from src/constants/index.js file to local variable in entrypoint src/index.js.. and also I changed the dependency of push-receiver to dev-master because it also causes build error if we use latest stable version..

Note: Create React App can consume both CommonJS and ES modules. For Node.js compatibility, it is recommended that the main entry point is CommonJS. However, they can optionally provide an ES module entry point with the module field in package.json. Note that even if a library provides an ES Modules version, it should still precompile other ES6 features to ES5 if it intends to support older browsers.

this is my fork: https://github.com/ydatech/electron-push-receiver

[MatthieuLemoine]

Fixed in v2.1.2 thanks to @NBoychev #36